-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared: Do not use @kind graph
for CFG test output
#17520
Conversation
fd5b237
to
1681324
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C# LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable, thanks for jumping on that!
The only comment I have is that the expected files remain somewhat hard to check for a human (more or less as before). But small diffs (as will usually be the case in a PR) are probably manageable.
Diffs are, IMO, easier to check in the non- |
I agree that typical PRs are probably easier to review now. The full expected file though remains pretty much imperscrutable 😅 |
The original motivation for using
@kind graph
was to be able to visualize CFGs in VS Code. However, now that we haveView CFG
, this is no longer needed. Moreover,@kind graph
often has spurious reorderings of the output, and there are some known limitations (such as missing multi-edges, IIRC), so it is not well suited for qltest.