Rust: update CODEOWNERS
#17461
Draft
Rust: update CODEOWNERS
#17461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibaars
requested changes
Sep 13, 2024
| @@ -12,6 +12,14 @@ | |||
| /java/kotlin-extractor/ @github/codeql-kotlin | |||
| /java/ql/test-kotlin1/ @github/codeql-kotlin | |||
| /java/ql/test-kotlin2/ @github/codeql-kotlin | |||
| /rust/extractor/ @github/codeql-rust-extractor | |||
There was a problem hiding this comment.
It feels a bit overkill to have 3 different sub-teams for a 5 person team ;-) Also the CODEOWNERS viewer complains that the teams do not exist yet. I guess we can start by creating @github/codeql-rust and make that the owner of all the files.
There was a problem hiding this comment.
Re: subteams, I got the request to have narrower teams to prevent notification overdrive, see slack. But we can reevaluate.
Re: team not existing, I think I did not follow the playbook from the internal process that should automate this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.