Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go/Java/C#: Rename ThreatModelFlowSource to ActiveThreatModelSource #17424

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Sep 10, 2024

  1. Go/Java/C#: Rename to ActiveThreatModelSource

    As part of adding support for threat-models to Python/JS (see
    github#17203), we ran into some trouble
    with name clashes.
    
    Naming in existing languages supporting threat-models:
    - `SourceNode` (for QL only modeling)
    - `ThreatModelFlowSource` (for active sources from QL or data-extensions)
    
    However, since we use `LocalSourceNode` in Python, and `SourceNode` in
    JS (for local source nodes), it seems a bit confusing to follow the same
    naming convention as other languages, and we had to come up with new names.
    
    Initially I used `ThreatModelSource` for the "QL only modeling", but
    that meant that we needed a new name to represent the active sources
    coming from either QL or data-extensions... for this I came up with
    `ActiveThreatModelSource`, and I really liked it. To me, it's much
    clearer that this class only contains the currently active threat
    model sources.
    
    So to align languages, I got approval from @michaelnebel to rename the
    existing classes.
    RasmusWL committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    038bc83 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Configuration menu
    Copy the full SHA
    8c10155 View commit details
    Browse the repository at this point in the history
  2. Go/Java/C#: Add change-note

    RasmusWL committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    66b61ee View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Go: autoformat

    RasmusWL committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    13a4df9 View commit details
    Browse the repository at this point in the history