Python: Model CookieWrites from HeaderWrites #16696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joefarebrother
force-pushed
the
python-cookie-write-headers
branch
from
8a1998e to
0901b3d
Compare
joefarebrother
changed the title
This was referenced Jul 2, 2024
RasmusWL
approved these changes
Jul 11, 2024
| { | ||
| CookieHeaderWrite() { | ||
| exists(StringLiteral str | | ||
| str.getText() = "Set-Cookie" and |
There was a problem hiding this comment.
should this be case sensitive? I see this was fixed later
Comment on lines
1249
to
1251
| override DataFlow::Node getNameArg() { | ||
| result = this.(Http::Server::ResponseHeaderWrite).getValueArg() | ||
| } |
There was a problem hiding this comment.
When I see this was fixed later.getHeaderArg is implemented, I would expect both name+value to be none().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/github/codeql-python-team/issues/792 promoting #6360; as well as a follow-up to #16105
This PR defines new instances of the
CookieWriteconcept in terms of theHeaderWriteconcept; as is done in experimental with theCookieconcept.