Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Neutralize some System.Diagnostics generated models #16091

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Apr 2, 2024

I don't think we'd ever want taint summaries for property setters, as they should be store steps instead (at least once #16088 is merged). This PR removes a few such taint summaries.

@github-actions github-actions bot added the C# label Apr 2, 2024
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Apr 2, 2024
@hvitved hvitved marked this pull request as ready for review April 2, 2024 17:21
@hvitved hvitved requested a review from a team as a code owner April 2, 2024 17:21
@michaelnebel
Copy link
Contributor

I don't think we'd ever want taint summaries for property setters, as they should be store steps instead (at least once #16088 is merged). This PR removes a few such taint summaries.

Should we strive for updating the model generator to reflect this?

Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hvitved
Copy link
Contributor Author

hvitved commented Apr 3, 2024

Should we strive for updating the model generator to reflect this?

Good idea.

@hvitved hvitved merged commit cccb11f into github:main Apr 3, 2024
22 checks passed
@hvitved hvitved deleted the csharp/system-diagnostics-modules branch April 3, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants