C#: Properly dispose diagnostic writer objects #16036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasvajk
force-pushed
the
autobuilder/disposable
branch
from
410b1af to
dadd4b9
Compare
michaelnebel
reviewed
Apr 2, 2024
michaelnebel
reviewed
Apr 2, 2024
|
Also, very good catch. How did you discover this? |
I was checking for #16021 how we write diagnostic messages, and I found that we have a disposable-like field. Also, I think it was only working before, because we call |
tamasvajk
force-pushed
the
autobuilder/disposable
branch
from
dadd4b9 to
fbec197
Compare
michaelnebel
reviewed
Apr 3, 2024
csharp/extractor/Semmle.Util/ToolStatusPage/DiagnosticsStream.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Nebel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.