Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: test MaD syntax for keyword argument #15903

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

yoff
Copy link
Contributor

@yoff yoff commented Mar 13, 2024

The test uses the combined positional/keyword syntax as that is what we will probably mostly use in practice.
We could easily add more tests here, I just want to ensure that this works (and keeps working).

use the combined positional/keyword syntax as
that is what we will probably mostly use.
@yoff yoff added the no-change-note-required This PR does not need a change note label Mar 13, 2024
@yoff yoff requested a review from a team as a code owner March 13, 2024 14:30
RasmusWL
RasmusWL previously approved these changes Mar 15, 2024
Copy link
Member

@RasmusWL RasmusWL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to sync the files, otherwise LGTM

@yoff
Copy link
Contributor Author

yoff commented Mar 22, 2024

I added a test for "ReturnValue.TupleElement[0,1]" inspired by this comment.

@yoff yoff requested a review from RasmusWL March 22, 2024 09:56
@RasmusWL
Copy link
Member

I added a test for "ReturnValue.TupleElement[0,1]" inspired by this comment.

Nice 💪

@RasmusWL RasmusWL merged commit d516db6 into github:main Mar 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-change-note-required This PR does not need a change note Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants