-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: add models for stdlib
#15306
Draft
yoff
wants to merge
43
commits into
github:main
Choose a base branch
from
yoff:python/add-stdlib-models
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoff
force-pushed
the
python/add-stdlib-models
branch
from
February 22, 2024 08:21
fe7523b
to
e4c22da
Compare
yoff
force-pushed
the
python/add-stdlib-models
branch
from
March 20, 2024 19:39
97e8085
to
28312bd
Compare
- `urllib.parse.urljoin` - `fnmatch.filter` - `optparse.parse_args` This brings the number of results for `py/shell-command-constructed-from-input` on a database for `tanghaibao/jvci` extracted without the standard lib up from 5978 to 17055. With the standard library, we get 17062 results.
looks nicer and allows easy evaluation of summaryLocalStep contribution
this should be removed in final version
does not recognize flow summary models yet
- elide any `Member[__init__]`
- summaries need to be vetted, all generated
Also attempt more modelling, but it seems to not have the intended effect. I should test the summary syntax for this.
- add hardcoded credentials query - better function names - better funtion paths
for easy debug, do not import all path-graphs import just the one(s) of interest instead
and sort the lines
it does not get evaluated by MRVA
- better argument path: collate positional and keyword arguments - better resturn path: method calls go to `ReturnValue` rather than `Argument[self:]`
it feels like it may get evaluated, just not reported, by MRVA
- add `Instance` - add `Subclass` - handle `self` argument properly - use newly generated models
also remove unused parameters
yoff
force-pushed
the
python/add-stdlib-models
branch
from
April 9, 2024 19:31
35e5844
to
ad4359e
Compare
recpgnise flow from `*args` and `**kwargs`
recover 3 alerts for `py/log-injection` on `zenml-io/zenml`
- add `self` as class instantiation
- understand `logging.getLoggerClass`
…dd-stdlib-models
…dd-stdlib-models
this preserves content
…dd-stdlib-models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urllib.parse.urljoin
fnmatch.filter
optparse.parse_args
This brings the number of results for
py/shell-command-constructed-from-input
on a database fortanghaibao/jvci
extracted without the standard lib up from 5978 to 17055. With the standard library, we get 17062 results.