PY: revert group sequences of chars #12514
Draft
+11
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I remember correctly the purpose of the change that gets reverted in this PR is to reduce the number of regex AST nodes by grouping sequences of normal characters into a single node instead of separate nodes for each character. Without this I think there is a risk of performance degradation for large strings (that may not even be actual regular expressions). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PR IS FOR NOTE-TAKING AND DISCUSSION, NOT FOR MERGING (yet)
This is a partial revert of https://github.com/github/codeql/pull/8166/files
I've updated the test-output to reflect the new results we gain from this revert.
This only touches Python, but Ruby/Java is also relevant.
CVE-2017-18361: TP
(Other security issue): TP (with constant-folding).