Skip to content

Commit

Permalink
Ruby: Add barrier guard flow tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@hvitved
hvitved committed Mar 20, 2024
1 parent f025430 commit 0f0acc0
Show file tree
Hide file tree
Showing 4 changed files with 177 additions and 0 deletions.
47 changes: 47 additions & 0 deletions ruby/ql/test/library-tests/dataflow/barrier-guards/barrier-flow.expected
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
testFailures
edges
| barrier_flow.rb:2:5:2:5 | x | barrier_flow.rb:4:10:4:10 | x | provenance | |
| barrier_flow.rb:2:9:2:17 | call to source | barrier_flow.rb:2:5:2:5 | x | provenance | |
| barrier_flow.rb:8:5:8:5 | x | barrier_flow.rb:11:14:11:14 | x | provenance | |
| barrier_flow.rb:8:9:8:17 | call to source | barrier_flow.rb:8:5:8:5 | x | provenance | |
| barrier_flow.rb:24:5:24:5 | x | barrier_flow.rb:26:10:26:10 | x | provenance | |
| barrier_flow.rb:24:9:24:17 | call to source | barrier_flow.rb:24:5:24:5 | x | provenance | |
| barrier_flow.rb:36:5:36:5 | x | barrier_flow.rb:42:10:42:10 | x | provenance | |
| barrier_flow.rb:36:9:36:17 | call to source | barrier_flow.rb:36:5:36:5 | x | provenance | |
| barrier_flow.rb:46:5:46:5 | x | barrier_flow.rb:50:10:50:10 | x | provenance | |
| barrier_flow.rb:46:9:46:17 | call to source | barrier_flow.rb:46:5:46:5 | x | provenance | |
| barrier_flow.rb:54:5:54:5 | x | barrier_flow.rb:62:10:62:10 | x | provenance | |
| barrier_flow.rb:54:9:54:17 | call to source | barrier_flow.rb:54:5:54:5 | x | provenance | |
| barrier_flow.rb:66:5:66:5 | x | barrier_flow.rb:78:10:78:10 | x | provenance | |
| barrier_flow.rb:66:9:66:17 | call to source | barrier_flow.rb:66:5:66:5 | x | provenance | |
nodes
| barrier_flow.rb:2:5:2:5 | x | semmle.label | x |
| barrier_flow.rb:2:9:2:17 | call to source | semmle.label | call to source |
| barrier_flow.rb:4:10:4:10 | x | semmle.label | x |
| barrier_flow.rb:8:5:8:5 | x | semmle.label | x |
| barrier_flow.rb:8:9:8:17 | call to source | semmle.label | call to source |
| barrier_flow.rb:11:14:11:14 | x | semmle.label | x |
| barrier_flow.rb:24:5:24:5 | x | semmle.label | x |
| barrier_flow.rb:24:9:24:17 | call to source | semmle.label | call to source |
| barrier_flow.rb:26:10:26:10 | x | semmle.label | x |
| barrier_flow.rb:36:5:36:5 | x | semmle.label | x |
| barrier_flow.rb:36:9:36:17 | call to source | semmle.label | call to source |
| barrier_flow.rb:42:10:42:10 | x | semmle.label | x |
| barrier_flow.rb:46:5:46:5 | x | semmle.label | x |
| barrier_flow.rb:46:9:46:17 | call to source | semmle.label | call to source |
| barrier_flow.rb:50:10:50:10 | x | semmle.label | x |
| barrier_flow.rb:54:5:54:5 | x | semmle.label | x |
| barrier_flow.rb:54:9:54:17 | call to source | semmle.label | call to source |
| barrier_flow.rb:62:10:62:10 | x | semmle.label | x |
| barrier_flow.rb:66:5:66:5 | x | semmle.label | x |
| barrier_flow.rb:66:9:66:17 | call to source | semmle.label | call to source |
| barrier_flow.rb:78:10:78:10 | x | semmle.label | x |
subpaths
#select
| barrier_flow.rb:4:10:4:10 | x | barrier_flow.rb:2:9:2:17 | call to source | barrier_flow.rb:4:10:4:10 | x | $@ | barrier_flow.rb:2:9:2:17 | call to source | call to source |
| barrier_flow.rb:11:14:11:14 | x | barrier_flow.rb:8:9:8:17 | call to source | barrier_flow.rb:11:14:11:14 | x | $@ | barrier_flow.rb:8:9:8:17 | call to source | call to source |
| barrier_flow.rb:26:10:26:10 | x | barrier_flow.rb:24:9:24:17 | call to source | barrier_flow.rb:26:10:26:10 | x | $@ | barrier_flow.rb:24:9:24:17 | call to source | call to source |
| barrier_flow.rb:42:10:42:10 | x | barrier_flow.rb:36:9:36:17 | call to source | barrier_flow.rb:42:10:42:10 | x | $@ | barrier_flow.rb:36:9:36:17 | call to source | call to source |
| barrier_flow.rb:50:10:50:10 | x | barrier_flow.rb:46:9:46:17 | call to source | barrier_flow.rb:50:10:50:10 | x | $@ | barrier_flow.rb:46:9:46:17 | call to source | call to source |
| barrier_flow.rb:62:10:62:10 | x | barrier_flow.rb:54:9:54:17 | call to source | barrier_flow.rb:62:10:62:10 | x | $@ | barrier_flow.rb:54:9:54:17 | call to source | call to source |
| barrier_flow.rb:78:10:78:10 | x | barrier_flow.rb:66:9:66:17 | call to source | barrier_flow.rb:78:10:78:10 | x | $@ | barrier_flow.rb:66:9:66:17 | call to source | call to source |
23 changes: 23 additions & 0 deletions ruby/ql/test/library-tests/dataflow/barrier-guards/barrier-flow.ql
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
/**
* @kind path-problem
*/

import codeql.ruby.AST
import codeql.ruby.CFG
import TestUtilities.InlineFlowTest
import codeql.ruby.dataflow.BarrierGuards
import PathGraph

module FlowConfig implements DataFlow::ConfigSig {
predicate isSource = DefaultFlowConfig::isSource/1;

predicate isSink = DefaultFlowConfig::isSink/1;

predicate isBarrier(DataFlow::Node n) { n instanceof StringConstCompareBarrier }
}

import ValueFlowTest<FlowConfig>

from PathNode source, PathNode sink
where flowPath(source, sink)
select sink, source, sink, "$@", source, source.toString()
28 changes: 28 additions & 0 deletions ruby/ql/test/library-tests/dataflow/barrier-guards/barrier-guards.expected
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ newStyleBarrierGuards
| barrier-guards.rb:276:5:276:7 | foo |
| barrier-guards.rb:282:5:282:7 | foo |
| barrier-guards.rb:292:5:292:7 | foo |
| barrier_flow.rb:19:14:19:14 | x |
| barrier_flow.rb:32:10:32:10 | x |
controls
| barrier-guards.rb:3:4:3:15 | ... == ... | barrier-guards.rb:4:5:4:7 | foo | true |
| barrier-guards.rb:3:4:3:15 | ... == ... | barrier-guards.rb:6:5:6:7 | foo | false |
Expand Down Expand Up @@ -331,3 +333,29 @@ controls
| barrier-guards.rb:291:6:291:6 | g | barrier-guards.rb:291:1:292:19 | [no-match] when ... | no-match |
| barrier-guards.rb:291:6:291:6 | g | barrier-guards.rb:292:5:292:7 | foo | match |
| barrier-guards.rb:291:6:291:6 | g | barrier-guards.rb:294:5:294:7 | foo | no-match |
| barrier_flow.rb:10:8:10:18 | ... != ... | barrier_flow.rb:11:9:11:14 | self | true |
| barrier_flow.rb:18:8:18:18 | ... == ... | barrier_flow.rb:19:9:19:14 | self | true |
| barrier_flow.rb:26:19:26:29 | ... == ... | barrier_flow.rb:26:5:26:10 | self | false |
| barrier_flow.rb:32:19:32:29 | ... != ... | barrier_flow.rb:32:5:32:10 | self | false |
| barrier_flow.rb:38:8:38:18 | ... != ... | barrier_flow.rb:39:9:39:9 | x | true |
| barrier_flow.rb:48:23:48:33 | ... == ... | barrier_flow.rb:48:5:48:5 | x | false |
| barrier_flow.rb:56:8:56:8 | b | barrier_flow.rb:57:9:57:14 | return | true |
| barrier_flow.rb:56:8:56:8 | b | barrier_flow.rb:57:9:57:34 | ... unless ... | true |
| barrier_flow.rb:56:8:56:8 | b | barrier_flow.rb:57:23:57:23 | x | true |
| barrier_flow.rb:56:8:56:8 | b | barrier_flow.rb:59:9:59:14 | return | false |
| barrier_flow.rb:56:8:56:8 | b | barrier_flow.rb:59:9:59:34 | ... unless ... | false |
| barrier_flow.rb:56:8:56:8 | b | barrier_flow.rb:59:23:59:23 | x | false |
| barrier_flow.rb:57:23:57:34 | ... == ... | barrier_flow.rb:57:9:57:14 | return | false |
| barrier_flow.rb:57:23:57:34 | ... == ... | barrier_flow.rb:57:9:57:34 | ... unless ... | true |
| barrier_flow.rb:59:23:59:34 | ... == ... | barrier_flow.rb:59:9:59:14 | return | false |
| barrier_flow.rb:59:23:59:34 | ... == ... | barrier_flow.rb:59:9:59:34 | ... unless ... | true |
| barrier_flow.rb:68:8:68:8 | b | barrier_flow.rb:69:9:71:11 | if ... | true |
| barrier_flow.rb:68:8:68:8 | b | barrier_flow.rb:69:12:69:12 | x | true |
| barrier_flow.rb:68:8:68:8 | b | barrier_flow.rb:70:13:70:18 | return | true |
| barrier_flow.rb:68:8:68:8 | b | barrier_flow.rb:73:9:75:11 | if ... | false |
| barrier_flow.rb:68:8:68:8 | b | barrier_flow.rb:73:12:73:12 | x | false |
| barrier_flow.rb:68:8:68:8 | b | barrier_flow.rb:74:13:74:18 | return | false |
| barrier_flow.rb:69:12:69:23 | ... != ... | barrier_flow.rb:69:9:71:11 | if ... | false |
| barrier_flow.rb:69:12:69:23 | ... != ... | barrier_flow.rb:70:13:70:18 | return | true |
| barrier_flow.rb:73:12:73:23 | ... != ... | barrier_flow.rb:73:9:75:11 | if ... | false |
| barrier_flow.rb:73:12:73:23 | ... != ... | barrier_flow.rb:74:13:74:18 | return | true |
79 changes: 79 additions & 0 deletions ruby/ql/test/library-tests/dataflow/barrier-guards/barrier_flow.rb
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
def m1
x = source(1)

sink x # $ hasValueFlow=1
end

def m2
x = source(2)

if x != "safe" then
sink x # $ hasValueFlow=2
end
end

def m3
x = source(3)

if x == "safe" then
sink x # $ guarded
end
end

def m4
x = source(4)

sink x unless x == "safe" # $ hasValueFlow=4
end

def m5
x = source(5)

sink x unless x != "safe" # $ guarded
end

def m6
x = source(6)

if x != "safe" then
x = "safe"
end

sink x # $ SPURIOUS hasValueFlow=6
end

def m7
x = source(7)

x = "safe" unless x == "safe"

sink x # $ SPURIOUS hasValueFlow=7
end

def m8(b)
x = source(8)

if b then
return unless x == "safe1"
else
return unless x == "safe2"
end

sink x # $ SPURIOUS hasValueFlow=8
end

def m9(b)
x = source(9)

if b then
if x != "safe1" then
return
end
else
if x != "safe2" then
return
end
end

sink x # $ SPURIOUS hasValueFlow=9
end

0 comments on commit 0f0acc0

Please sign in to comment.