Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

[WIP] Adding more detail to PullRequestCheckView #2013

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
25952ef
Adding a second line to Checks in the PullRequestCheckView
StanleyGoldman Oct 25, 2018
6c2e1c8
Update checks list layout
donokuda Oct 25, 2018
2a8b50f
Little bit of spacing and some text color formatting
donokuda Oct 25, 2018
7a288d1
Merge branch 'master' into check-second-line
StanleyGoldman Oct 30, 2018
632c9fb
Making duration status a tooltip
StanleyGoldman Oct 30, 2018
406c5d4
Allow functionality to set ProtectedBranches
StanleyGoldman Oct 31, 2018
8518c42
Merge branch 'octokit-graphql-update' into protected-branches
StanleyGoldman Nov 1, 2018
7e185c3
Merge branch 'master' into check-second-line
StanleyGoldman Nov 2, 2018
0b979b3
GraphQL fix
StanleyGoldman Nov 2, 2018
e17b44b
Adding a second check for differing non-required statuses
StanleyGoldman Nov 2, 2018
bc92842
Adding a required tag to PullRequestCheckViewModel
StanleyGoldman Nov 2, 2018
5d0c825
Fix compilation error
StanleyGoldman Nov 2, 2018
73134d9
Merge branch 'master' into protected-branches
StanleyGoldman Nov 2, 2018
c816c8d
Merge branch 'master' into check-second-line
StanleyGoldman Nov 6, 2018
a7e3fcb
Merge branch 'master' into check-second-line
StanleyGoldman Nov 8, 2018
1d0b8d2
Merge remote-tracking branch 'origin/master' into check-second-line
StanleyGoldman Dec 12, 2018
6e03523
Fixes needed for compilation
StanleyGoldman Dec 12, 2018
51a00c7
Fixing formatting
StanleyGoldman Dec 12, 2018
cefc43a
Merge remote-tracking branch 'origin/master' into check-second-line
StanleyGoldman Dec 13, 2018
a489cbe
Fxing how the model is populated
StanleyGoldman Dec 13, 2018
8f91ca3
Merge remote-tracking branch 'origin/master' into protected-branches
StanleyGoldman Dec 13, 2018
3f0ac46
Merge branch 'check-second-line' into protected-branches
StanleyGoldman Dec 13, 2018
f25c488
Reverting functionality to process protected branches in the pull req…
StanleyGoldman Dec 13, 2018
1cf3c80
Repositioning
StanleyGoldman Dec 13, 2018
018fdab
Cleanup
StanleyGoldman Dec 13, 2018
bda657a
Merge pull request #2029 from github/protected-branches
StanleyGoldman Dec 13, 2018
95bb822
Comments
StanleyGoldman Dec 13, 2018
b7d9d2e
Removing unused enum
StanleyGoldman Dec 13, 2018
20690ea
More comments
StanleyGoldman Dec 13, 2018
a3cb52f
Flailing a little
donokuda Dec 13, 2018
1a46be8
Use a dock panel layout
donokuda Dec 14, 2018
2a9402e
Theming
donokuda Dec 14, 2018
6691ab7
uncomment visibility condition
donokuda Dec 14, 2018
fbf9bef
Merge branch 'master' into check-second-line
StanleyGoldman Feb 26, 2019
6fb41a2
Merge branch 'master' into check-second-line
StanleyGoldman Feb 26, 2019
fa4add2
Fixing view
StanleyGoldman Feb 26, 2019
f3b746c
Fix line spacing issues between check titles and descriptions
donokuda Feb 27, 2019
8bec5f0
Leave enough space for the Required Badge
donokuda Feb 27, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Flailing a little
donokuda committed Dec 13, 2018
commit a3cb52fb98d67a3ba26f3608aef007f012dcade5
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@
</ResourceDictionary>
</Control.Resources>

<Grid>
<Grid Margin="0 0 0 8">
<Grid.ColumnDefinitions>
<ColumnDefinition Width="Auto"/>
<ColumnDefinition Width="*"/>
@@ -31,8 +31,8 @@
</Grid.ColumnDefinitions>

<Grid.RowDefinitions>
<RowDefinition MaxHeight="32"/>
<RowDefinition MaxHeight="32"/>
<RowDefinition Height="Auto"/>
<RowDefinition Height="Auto"/>
</Grid.RowDefinitions>

<ghfvs:OcticonImage Grid.Column="0" Grid.Row="0" Margin="0 0 4 0" Icon="check" Foreground="#2cbe4e" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Success}}"/>
@@ -53,19 +53,17 @@
</Label>
</StackPanel>

<Label Grid.Column="2" Grid.Row="1" HorizontalContentAlignment="Stretch" Visibility="{Binding HasAnnotations, Converter={ghfvs:BooleanToVisibilityConverter}}">
<Label Grid.Column="2" Grid.Row="1" HorizontalContentAlignment="Right" Visibility="{Binding HasAnnotations, Converter={ghfvs:BooleanToVisibilityConverter}}">
<Hyperlink ToolTip="View checks"
Command="{Binding Path=DataContext.ShowAnnotations, RelativeSource={RelativeSource Mode=FindAncestor,AncestorType={x:Type local:PullRequestDetailView}}}"
CommandParameter="{Binding}">
Checks
</Hyperlink>
</Label>

<Label Grid.Column="3" Grid.Row="1" HorizontalContentAlignment="Stretch" Visibility="{Binding DetailsUrl, Converter={ghfvs:NullToVisibilityConverter}}">
<Label Grid.Column="3" Grid.Row="1" HorizontalContentAlignment="Right" Visibility="{Binding DetailsUrl, Converter={ghfvs:NullToVisibilityConverter}}">
<Hyperlink ToolTip="{Binding DetailsUrl}" Command="{Binding OpenDetailsUrl}">Details</Hyperlink>
</Label>


</Grid>
</local:GenericPullRequestCheckView>