This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
Modify notifyClassroom to have correct autograding tests #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
check_nameto match the autograding workflow file that is generated on the classroom side. This essentially won't matter too much as we have changed the Classroom webhook event handler to find by the head sha, which will be more secure and more robust for teachers to create their own workflow and not have to use the "run-autograding-tests" check name.In addition, because the
output.summaryandoutput.textare being written as the same things, we changed it sooutput.textis a JSON string which we will parse on the Classroom side of things and make it easier.Again, so if teachers want to modify/create their own reporter, they don't need to use the exact regex we have been looking for (ie. "Points x/x). This will make things more flexible and easier to understand on this side of things, since our API is not open source.