Changing functionality to allow Oauth if template auth does not exist. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giteshk
reviewed
Sep 6, 2018
| $entity = reset($entity); | ||
| $client_id = $entity->consumerKey; | ||
| $client_secret = $entity->consumerSecret; | ||
| } |
There was a problem hiding this comment.
I get what you are trying to do. But if the key does not have the OAuth API Product the token would not be generated and the user would not know why this happens.
Do you think we can create an admin page to store default credentials to use (which administrators set) incase template auth don't exist?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the smartdocs_oauth_additions_form_generate_token function workflow to allow Oauth if the model does not have a template auth setup.