Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editable HighlightView Implementation #16

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

tusharsadhwani
Copy link

@tusharsadhwani tusharsadhwani commented Aug 2, 2020

Expands on the implementation in PR #13

  • Adds a controller property to HighlightView, so people can provide text via text property or via controller property

  • Add an editable property, which if true, renders a TextField instead of a RichText

  • Updated the example to use editable HighlightView

Fixes #3
Fixes #6

@tusharsadhwani
Copy link
Author

@dutrieuc @pd4d10 thoughts?

@dutrieuc
Copy link

dutrieuc commented Aug 4, 2020

Seems good to me !

@waf
Copy link

waf commented Nov 6, 2020

I've used @tusharsadhwani's branch in a small side project of mine, and it's working beautifully! It'd be good to get this merged. 👍

@tusharsadhwani
Copy link
Author

Since this project seems kinda abandoned, and since the subdirectory-based structure of this repo doesn't let you directly add a fork's github URL in your pubspec.yaml to modify and use this project, I've taken the liberty of copying the flutter_highlight part of this repo into my own (although I have credited the original).

You can use my fork in your projects by doing this in your pubspec.yaml:

dependencies:
  flutter:
    sdk: flutter
  highlight: ^0.6.0
  flutter_highlight:
    git: https://github.com/tusharsadhwani/flutter_highlight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add method to get the List of TextSpan TextFields support?
3 participants