Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesigned website #28

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Conversation

prertik
Copy link

@prertik prertik commented Nov 29, 2020

We all have experienced https://gitforwindows.org/ was broken for some time. Broken in a sense, it wasn't responsive and showed weird scaling on big monitors, and looked bad in mobile view. So, rather than raise an issue and burden the maintainer to fix that, I took out some free time and redesigned it. This doesn't use any prevalent frameworks like Jekyll, Hugo, and such. It just has an index.html and some CSS and uses bootstrap from CDN to give us a responsive simple website. I also have add .nojekyll file so that it can be easily hosted from Github.

Furthermore, I didn't remove the unnecessary CSS files and js as there might be other pages which might depend on that so, to not break stuff, I didn't dare.

I haven't updated on governance model page as I believe some revision can be made on that and maybe can be placed in this same index.html page.

P.S. I am not very good at designing and doing frontend and do have some limitations to what I can do. 😉

Here's the index.html in all it's glory.
gitforwindowscomplete

Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple concerns and suggestions ;-)

css/custom.css Outdated Show resolved Hide resolved
css/custom.css Show resolved Hide resolved
css/style.css Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
<meta name="description" content="We bring the awesome Git VCS to Windows">
<meta name="viewport" content="width=device-width, initial-scale=1">
<link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Open+Sans:300,400,700">
<link rel="stylesheet" href="css/pack.css">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pack.css is built by the Gruntfile.js.

If we do not use that any longer, we might just as well do away with style.css completely (rather than changing it to no effect).

We would then also need to drop grunt and friends from the package.json file.

But then, how can we ensure a common look between index.html, governance-model.html and requirements.html (the latter two are generated from Markdown using the markdown-template.html file).

In a similar vein, we render the Release Notes of Git for Windows using this script and this CSS, which is a copy-edited version of the css/style.css file in this here repository. If we change the look of the home page, we will have to align the look of the release notes accordingly.

@prertik
Copy link
Author

prertik commented Dec 9, 2020

I'll re-iterate this to resolve your valid comments @dscho.

@dscho
Copy link
Member

dscho commented Dec 9, 2020

I'll re-iterate this to resolve your valid comments @dscho.

Thank you!

@prertik prertik force-pushed the new-design branch 2 times, most recently from 4952667 to 166a796 Compare November 1, 2021 15:30
@dscho
Copy link
Member

dscho commented Nov 3, 2021

Thank you for working on this @prertik! I pushed this branch to my fork, re-set the Pages configuration to build from that branch, and see a nice, clean web page. It might actually be a little too clean, leaving quite a bit of empty, unused space:

image

However, when I look at it at 800x600, it looks like this:

image

And when I ask Screenfly how it would look on iPhone/iPad, it looks like this:

image

I looked at a couple other mobile phone resolutions and it looks similar. Note the horizontal scrollbar, which I would really like to avoid.

I also noticed that clicking on the menu button in the upper right does not pop up any menu.

Finally: I would like to see this addressed:

I do not see any mention of the current version. We added that information specifically, at the top of the page, based on user feedback that this is one of the first things people are looking for. Could we have that back?

and

This "version" line is very special: it is used by the automation after new Git for Windows versions are released. Removing this line will break the automation.

Hmmm, this seemed way out of place in the original design, and I found most projects do not simply display that and point to the latest releases, but, in this case, since, it's important, I'll revisit this.

@dscho
Copy link
Member

dscho commented Nov 3, 2021

Also note that https://dscho.github.io/git-for-windows.github.io/#download-sdk needs to scroll the SDK download button/link into view. I refer to this a ton on the bug tracker.

@dscho
Copy link
Member

dscho commented Nov 3, 2021

I also noticed that clicking on the menu button in the upper right does not pop up any menu.

I fear that this might have something to do with:

$ git grep navbar-toggler
index.html:                     class="navbar-toggler"><span class="navbar-toggler-icon"></span></button>

There should probably be more hits than just this line. I would have imagined at least an entry in the .css file.

@prertik prertik requested a review from dscho November 13, 2021 07:43
prertik and others added 15 commits November 18, 2021 13:36
Signed-off-by: Pratik Karki <[email protected]>
Signed-off-by: Pratik Karki <[email protected]>
Signed-off-by: Pratik Karki <[email protected]>
Signed-off-by: Pratik Karki <[email protected]>
Signed-off-by: Pratik Karki <[email protected]>
* Fix for navbar while on small device
* Add version of git for windows available
* Other minor UI fixes

Signed-off-by: Pratik Karki <[email protected]>
Signed-off-by: Pratik Karki <[email protected]>
@prertik
Copy link
Author

prertik commented Nov 18, 2021

Hi @dscho! Please review when you have a few minutes.

Copy link
Member

@mjcheetham mjcheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Had a few opinions on the logos and casing use.

index.html Outdated
Comment on lines 27 to 29
<h1 class="gittext lowercase">
Git<span>for Windows</span>
</h1>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having "Git for Windows" stylised as "git for windows" feels weird. It should probably be capitalised normally IMO.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind the styling (it's carried over from the current incarnation), but I do mind the new font. Especially the g in git:

Current:
current

Proposed:
proposed

The closed descender on the g felt more like a logotype.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjcheetham I tried to keep true to the original design so the re-use.
@vtbassmatt, makes sense. Looks like I have to remain true to original font too.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prertik Ah, beat me to it. I was going to say, this matches the current Git for Windows homepage (and https://git-scm.com/):
image

index.html Outdated
class="navbar-toggler"><span class="navbar-toggler-icon"></span></button>
<div id="navbarSupportedContent" class="collapse navbar-collapse">
<ul class="navbar-nav ml-auto">
<li class="nav-item"><a style="font-weight:bold" href="https://github.com/git-for-windows/git/wiki/FAQ"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "FAQ" link being bold and the others not, makes it stand out for the wrong reason.
Looks like "FAQ" is a category or label for the other links to the right, rather than being a link itself.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FAQ is a link to Github's wiki page where FAQ content is. In the original design too, it was bold, so remaining true. We can tone down the boldness.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's remove the boldness. The original idea was to guide users to the FAQ, but I don't believe that it worked.

Copy link

@vdye vdye Nov 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's bold because it's an internal link, but the others are external. If you do want to un-bold it, you could use an icon indicator (like a box arrow) to show that the external links are external (and open in a new tab).

EDIT: they're all external links, you can ignore what I have written here 🙂

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC I emboldened the link to provide an easy visual for those looking for the FAQs, and consequently the whole wiki, to find. I'd hate to loose the 'easy to find' aspect. Alternate designs that help folks find, and look up, all those FAQ & wiki items would be just as reasonable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that our strategy worked. The FAQ was not easy to find, neither was the wiki.

But maybe that's all okay, now that we have GitHub Discussions. It seems the StackOverflow-like format fits more people's needs than the wiki format.

index.html Outdated
<div class="container">
<div class="row">
<div class="col-lg-6 order-2 order-lg-1">
<img src="img/gwindows_logo.png" alt="Git Logo" class="img-fluid">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the logo is large, or even just viewed on a HiDPI screen it looks blurry. We should probably use an SVG here so it's always crisp.

index.html Outdated
<div class="row">
<div class="col-sm-6 col-lg-4 mb-3">
<img src="img/gw1web_thumb.png" alt="Git BASH" class="img-other-logos">
<h3>Git BASH</h3>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The all-caps "BASH" here stands out, and looks odd. Although it stands for Bourn Again SHell, it's normally stylised as "Bash": https://www.gnu.org/software/bash/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was copied over but makes sense, will change.

Screen Shot 2021-11-18 at 8 20 11 PM

<div class="container">
<div class="row">
<div class="col-md-6">
<span>Copyright © 2020 Johannes Schindelin and contributors. All rights reserved.</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2021?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legally kind of a grey zone (to be clear, I am not a lawyer and this is not legal advice 😁.) Current practice at GitHub is to say simply "Copyright © Johannes Schindelin and contributors", dropping both the date and the "all rights reserved" text. I'm not sure how other companies/projects do it, nor what advice Johannes and contributors have received.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what advice Johannes and contributors have received

I haven't received any, apart from what you just said. I am in favor of dropping the parts you suggested to drop.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, dropping these then.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2021?

@mjcheetham It's 2021 ALREADY???

Sorry. Had to do this.

index.html Outdated
<nav class="navbar navbar-light navbar-expand-lg fixed-top shadow-sm bg-white">
<a href="index.html" class="navbar-brand">
<h1 class="gittext lowercase">
Git<span>for Windows</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like the Git for Windows logo should also appear next to the title in the nav bar. Git for Windows doesn't really have a "wordart", only a logo and name. Should probably use the logo where we want to use the "Git for Windows" text as a title or wordart.

index.html Outdated
<p>Please look at the <a href="https://github.com/git-for-windows/git/wiki/Technical-overview">technical
overview</a> of the Git for Windows packaging and how to include your changes in your own custom
installer.</p>
<a name="download-sdk" /><a class="btn btn-outline-primary shadow mr-2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making this download button a btn-outline-primary means it doesn't look like the other action buttons on the page. Probably would look better as just btn-primary IMO.

Copy link

@vtbassmatt vtbassmatt Nov 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Counterpoint: it's good to have one clear call-to-action button and reduce the emphasis on other actions. I'd probably alter the "Issue tracker" button below to be outline, then there's exactly one color-forward button and the rest are muted.

edit: Whoops, I thought this comment was someplace else. My feedback is different so I'll put it in the right place.

index.html Outdated
<a class="btn btn-primary shadow mr-2" href="https://github.com/git-for-windows/git/issues"
target="_blank">Issue Tracker</a>
<br>
<img src="img/details_contribute.png" class="rounded float-left img-git-logo" alt="Git for Windows Logo">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "git SDK" image here looks.. weird. The drop shadow on the text almost has a blue tinge to it?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't 👍 this one enough. Can we get a render of the Git SDK logo that's full-alpha so that it works on any background, maybe?

index.html Outdated
<div>
<div class="col-md-6 col-md-offset-3 col-md-push-3">
<div class="text-right">
<p class="lead">
<h2>We bring the awesome <span class="gittext">Git</span> SCM to Windows</h2>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're going to the trouble of making a change, could we consider dropping SCM from the heading? Any of the following would be preferable:

  • We bring Git to Windows
  • We bring the power of Git to Windows
  • Git + Windows = awesome

I know it's baked into the upstream Git domain name, but in my experience, few people use this term anymore. The Git homepage itself uses it only in a derisive way (emphasis mine):

Git is a free and open source distributed version control system designed to handle everything from small to very large projects with speed and efficiency.

Git is easy to learn and has a tiny footprint with lightning fast performance. It outclasses SCM tools like Subversion, CVS, Perforce, and ClearCase with features like cheap local branching, convenient staging areas, and multiple workflows.

</section>
<section>
<div class="container">
<h2>Tools &amp; Features</h2>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that these now lay out side by side rather than stacked. However, the images aren't the same height, and so there's a "bunting" effect that isn't pleasing.

patriotic screenshots

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, I just spent an incredible 1h15m on re-generating the screenshots and on opening #33.

index.html Outdated
<p>If you've noticed a bug or simply have an idea that you'd like to see become real, why not work on it?
Bug reports and feature requests are typically submitted to the issue tracker on our GitHub repository.
</p>
<a class="btn btn-primary shadow mr-2" href="https://github.com/git-for-windows/git/issues"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this is a button orphaned below a paragraph.

orphan

It would look nicer to fold it into the paragraph and de-button-ify it. (That said, I see merit in having a button link to the issue tracker somewhere on the page - perhaps with other buttons so it's not out of place?)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't understand why it's a btn-primary when there's already a btn-primary on the page. If a button remains, it should be btn-outline-primary to reduce its emphasis (it's not the core CTA on the page).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vtbassmatt I agree but the question here. is if we are already providing an issue tracker like on a navbar like the FAQ and others, why keep a Bug Reports section on the website at all?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prertik that's a fine question! Looking at another friendly project, Django, I see that they have a header with "Community", "Code", and "Issues" explicitly separated. (This makes sense since they use a mailing list/IRC, GitHub, and some legacy bug tracker respectively.)

Django

Then way down the page, in the sidebar, they use a very short section of the column to repeat their connections to community-oriented stuff.

image

I think we could probably live without the large paragraph here, if you're keen to remove it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining! Okay, I'll try this and see how this looks.

@prertik
Copy link
Author

prertik commented Nov 18, 2021

@vtbassmatt, I agree with most of your well-reviewed comments but I do not agree with the "welcoming color" opinion.
To my eyes(I am not a designer nor I'm a frontend developer), previous design's use of excessive blue struck me though, I understand it was to give a windows-y feel. Now, I don't even think, windows are sticking with that shade of blue. I like blue to highlight buttons or hyperlinks but, adding blue to headers and other parts gives me the impression of using Facebook. 🤷🏾
I think a simple clean white background with black text with blue buttons or for hyperlinks and a good logo is easy on the eyes to find proper information.

@dscho What's your opinion on this?

@dscho
Copy link
Member

dscho commented Nov 18, 2021

I guess sticking with a variant of the blue theme would help with not completely tripping up Git for Windows users who expect a dark blue page.

@prertik
Copy link
Author

prertik commented Nov 18, 2021

I guess sticking with a variant of the blue theme would help with not completely tripping up Git for Windows users who expect a dark blue page.

@dscho
So, I think we should keep a tag-line, "Come for the blue, leave with git for windows" 🤣 🤣

Copy link

@vdye vdye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together! These are mostly my initial impressions - after the other review feedback is addressed, I'm planning on giving it another (more fine-grained) look.

index.html Outdated
<meta name="viewport" content="width=device-width, initial-scale=1">
<meta name="robots" content="all,follow">
<!-- Bootstrap CSS-->
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.5.3/css/bootstrap.min.css">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.5.3/css/bootstrap.min.css">
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/bootstrap@4.6.1/dist/css/bootstrap.min.css" integrity="sha384-zCbKRCUGaJDkqS1kPbPd7TveP5iyJE0EjAuZQTgFLD2ylzuqKfdKlfG/eSrtxUkn" crossorigin="anonymous">

The recommended CDN by Bootstrap is jsDelivr/BootstrapCDN - was there a specific reason you went with Cloudflare? Also, regardless of the CDN used, please include the SRI hash. Both jsDelivr and Cloudflare have them available.

index.html Outdated
Comment on lines 27 to 29
<h1 class="gittext lowercase">
Git<span>for Windows</span>
</h1>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prertik Ah, beat me to it. I was going to say, this matches the current Git for Windows homepage (and https://git-scm.com/):
image

index.html Outdated
Comment on lines 165 to 166
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.6.0/jquery.slim.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.5.3/js/bootstrap.bundle.min.js"></script>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as before - should probably use jsDelivr for these (including JQuery), and include SRI hashes for each of them (especially being JS files).

index.html Outdated
<!-- JavaScript files-->
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.6.0/jquery.slim.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.5.3/js/bootstrap.bundle.min.js"></script>
<script src="https://cdn.linearicons.com/free/1.0.0/svgembedder.min.js"></script>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used/why is it needed? I don't see any SVGs used here (although I could definitely be missing something).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I mistakenly put this line but, now it will have a purpose in the next iterations.

Copy link

@vdye vdye Nov 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need a special JS library to embed SVGs (source), so this can still be removed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will see if it works that way.

Comment on lines +34 to +35
'css/small.css',
'css/custom.css'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There doesn't really seem to be a place for this comment, but the new design is really harsh on the eyes for those with "dark mode" enabled. This wasn't a problem with the original site, as it used more muted greys/blues rather than a stark white background.

If possible, could you use something like prefers-color-scheme to develop a light- and dark-mode palette? Or, if that's a lot of additional work, tone down the brightness of the current design to the grey/blue theme of the original?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could go through that light/dark mode route, but, it seems everyone wants the blue back even the project maintainer themselves, so, will work on that.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, getting to proper dark is very challenging it seems, as people seem to prefer different shades of dark, it took even Github couple of iterations to figure that out so, 🤷🏾‍♂️

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vdye I can't seem to reply below on this: #28 (comment)

Won't it look a bit bad and dated to have those types of box arrow buttons on the navbar?
We can do for other buttons below but, 🤷🏾‍♂️

Copy link

@vdye vdye Nov 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's good enough for Google and their (probable) army of UI designers, it's probably fine. 🙂 (although I know I see it all the time on other modern sites - once you want to look for something, it somehow becomes impossible to find it).

Copy link

@vdye vdye Nov 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That being said, I don't want to dictate how you show the internal/external link distinction (a box arrow is just one option). All I'm really looking for is something distinguishing the two. Color of the text, boldness of the text, icons, etc. are all possibilities, plus others I'm probably not thinking of.

EDIT: they're all external links - with that in mind, you probably don't need any extra emphasis other than potentially bolding the FAQ (for the reasons mentioned in the other comment)

index.html Outdated
class="navbar-toggler"><span class="navbar-toggler-icon"></span></button>
<div id="navbarSupportedContent" class="collapse navbar-collapse">
<ul class="navbar-nav ml-auto">
<li class="nav-item"><a style="font-weight:bold" href="https://github.com/git-for-windows/git/wiki/FAQ"
Copy link

@vdye vdye Nov 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's bold because it's an internal link, but the others are external. If you do want to un-bold it, you could use an icon indicator (like a box arrow) to show that the external links are external (and open in a new tab).

EDIT: they're all external links, you can ignore what I have written here 🙂

@vtbassmatt
Copy link

Come for the blue, leave with git for windows

🤣 thank you for the good humor about my feedback! I don't think it has to be blue, and I can agree that maybe the current blue is "too much". The problem I want to correct is the blank sterility.

If it were 2015, I guess we would do some kind of tessellating low-poly texture. 2008, we'd be doing a skeuomorphic pool table. I'm not sure what's in fashion now, so that in 5 years we can look back and see how dated it all feels 🤪

@prertik
Copy link
Author

prertik commented Nov 18, 2021

blank sterility

What's that? I understand you mean the blank parts in the website but, why this term as I think sterility has a different meaning?

@vtbassmatt, I had to google lots of things. 😃

@prertik
Copy link
Author

prertik commented Nov 18, 2021

Also, @dscho mentioned that this looks bad in iPad mini and it does. On iPad and iPhone, and other devices it's fine.
Any idea on how to fix this @vdye @vtbassmatt @mjcheetham?

@prertik
Copy link
Author

prertik commented Nov 18, 2021

Also, @dscho mentioned that this looks bad in iPad mini and it does. On iPad and iPhone, and other devices it's fine. Any idea on how to fix this @vdye @vtbassmatt @mjcheetham?

Okay, confirmed again, looks like it's broken for tab and other devices with 768 pixels width. Okay, that makes sense.

@vdye
Copy link

vdye commented Nov 18, 2021

Also, @dscho mentioned that this looks bad in iPad mini and it does. On iPad and iPhone, and other devices it's fine. Any idea on how to fix this @vdye @vtbassmatt @mjcheetham?

Looks like it's because you use col-md-6 for the text block and col-lg-6 for the image. If you use the same for both (either both md or both lg), it's somewhat more consistent (although still kind of weird because of the alignment within those columns):

image

@prertik
Copy link
Author

prertik commented Nov 18, 2021

Also, @dscho mentioned that this looks bad in iPad mini and it does. On iPad and iPhone, and other devices it's fine. Any idea on how to fix this @vdye @vtbassmatt @mjcheetham?

Looks like it's because you use col-md-6 for the text block for one and col-lg-6 for the image. If you use the same for both (either both md or both lg), it's somewhat more consistent (although still kind of weird because of the alignment within those columns):

Okay, will try that. Thanks!

@vtbassmatt
Copy link

What's that? I understand you mean the blank parts in the website but, why this term as I think sterility has a different meaning?

D'oh, sorry: definition 2c. "lacking in stimulating emotional or intellectual quality : lifeless // as in 'a sterile work of art'"

@vtbassmatt, I had to google lots of things. 😃

I'm sorry! I'll try to communicate more clearly and succinctly -- I have a bad habit of being wordy.

@prertik
Copy link
Author

prertik commented Nov 18, 2021

What's that? I understand you mean the blank parts in the website but, why this term as I think sterility has a different meaning?

D'oh, sorry: definition 2c. "lacking in stimulating emotional or intellectual quality : lifeless // as in 'a sterile work of art'"

@vtbassmatt, I had to google lots of things. 😃

Oh makes sense. Thanks for explaining.

I'm sorry! I'll try to communicate more clearly and succinctly -- I have a bad habit of being wordy.

No no. It's awesome, I'm happy to learn new things. 😃

@dscho
Copy link
Member

dscho commented Nov 19, 2021

I don't think it has to be blue, and I can agree that maybe the current blue is "too much". The problem I want to correct is the blank sterility.

Maybe as a compromise, we could have a light-blue background in the banner on top (the one that says "git for windows")?

@dscho dscho mentioned this pull request Nov 19, 2021
* Change git in logo to lowercase git with proper font
* Use SVG logos
* Remove copyright from footer and redesign footer
* Add Issues to navbar
* Remove Boldness from FAQ
* Use cdn.jsdelivr.net with SRI for obtaining script files
* Remove issue tracker button
* Reword the Git tagline
* Other minor fixes

Signed-off-by: Pratik Karki <[email protected]>
Signed-off-by: Pratik Karki <[email protected]>
@prertik
Copy link
Author

prertik commented Nov 19, 2021

New updated website here: https://prertik.github.io/git-for-windows.github.io

@vtbassmatt
Copy link

vtbassmatt commented Nov 19, 2021

@prertik the new design is definitely addressing the concerns I had 😁 Two newly-introduced nitpicks (as a result of you reacting to all our others, no doubt!):

Yeah, the "sea of blue" is now distracting more than it's making the page feel nice. I think because you've got some solid, dark blue in the top bar, we could drop the body section to a light gray (I tried #dddddd and #dddde0, both seemed OK to my eye).

The links in the header and footer fail WCAG guidelines for contrast (and subjectively, seem too similar to me). In the spirit of inclusiveness, I want to make sure even folks with reduced color vision or eyesight have an easy time seeing the important bits. The design (at least as it's posted on your .github.io as of this writing) has a #1B468A background for the header and footer. In the table below, I've laid out what you're currently proposing and the failing contrast ratio, along with a potential new color and its contrast ratio.

Element @prertik color Contrast ratio Possible color New contrast ratio Notes
Header #87A2C4 ~3.5 #C2D1E1 ~5.9 See below*
Footer at rest #878787 ~2.5 #BBBBBB >4.5
Footer on hover #007BFF 2.3 #80BDFF >4.5

*The header text is defined as pure-white and 50% alpha. I went to 75% alpha to get my numbers, which resulted in that huge contrast ratio. We only need to get to 4.5 to be within guidelines, so there's lots of wiggle room there if you want to keep the text more on the dim side.

@prertik
Copy link
Author

prertik commented Nov 20, 2021

Thank you @vtbassmatt for the proper explanation. I'll iterate.

@dscho
Copy link
Member

dscho commented Nov 20, 2021

I tried a couple of things on top, and pushed to my fork. This is how it looks here:

image

(Note: I had to cheat via Developer Tools to force the "Git for Windows" text to 1rem on the left, I did not find any way to do this with Bootstrap.)

What do you think?

@prertik
Copy link
Author

prertik commented Nov 21, 2021

Looks good, @dscho. The alignment is slightly off with the logo center. I think we also need somewhat more work on the website (as I and @dscho discussed over chat), I'll try to use some tools for mocking and share the links/screenshots here before I code it away.

@adsingh14

This comment has been minimized.

@dscho

This comment has been minimized.

@adsingh14

This comment has been minimized.

@dscho

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants