Search parent directories for .git dir #128
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into the issue described in #113 today. While I like the rev-parse idea and have seen that implemented in other places, I just opted to search parent directories until I find a .git directory within one.
To keep the tests passing, I had to modify them to use a different sandbox directory--one not parented by the project, otherwise the recursive parent calls would pick up the maven-git-command-id-plugin's git directory mistakenly.
This is working great for me now, but I welcome feedback.