add alternates to valhalla #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I actually think we need some general re-write of all of this.. We've been patching a lot of shit in the past 12 months, like the static functions so we can use its logic outside of routingpy. All the typing is really off. Now I saw we're generally returning a |
nilsnolde
commented
Aug 2, 2023
| factor = 0.621371 if units == "mi" else 1 | ||
| distance += int(leg["summary"]["length"] * 1000 * factor) | ||
| def parse_direction_json(response, units, alternatives): | ||
| routes = response["alternates"] + [response] if alternatives else [response] |
There was a problem hiding this comment.
oops, this needs to be the normal route first as that's the lowest cost
chrstnbwnkl
approved these changes
Aug 3, 2023
|
I was just very surprised by the weird conflicts, turns out you accidentally approved the wrong pull request 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't do a test. I'd wait for #85 to be merged and do a live test.