-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract caching and support entrypoints #876
Conversation
@manthey, this seems to be working and is tested downstream.I'm ready for a final review if you have time |
Can we also tag 1.14.6 (or should this be 1.15 since there is a new interface) after this merges? |
Excellent. |
That should work correctly. |
It will be 1.15.0 since I think this is enough of a new interface. |
Abstracts the caching mechanism so that external projects can implement a cache interface and use entrypoints to make it available to large_image.
Generally, this is working for django-large-image with girder/django-large-image#32
Todo:
MemCache
cache be chosen appropriately? Is it ignored when not available and is it chosen overpython
when available?loadCaches()
only be called once rather than on everyCacheFactory.getCache()
call?CacheFactory.getCacheSize()
andpickAvailableCache()
and how are they affected by these changes?BaseCache.getCache()
returns aNone
cache lock? can/should we support that?django-large-image