Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand user directory for FileTileSource paths. #746

Merged
merged 1 commit into from
Dec 20, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
# Change Log

## Unreleased

## Version 1.9.0

### Improvements
- Expand user paths ([#746](../../pull/746))

### Features
- Better palette support in styles ([#724](../../pull/724))
- Enumerate available palettes ([#741](../../pull/741))
Expand Down
6 changes: 3 additions & 3 deletions large_image/tilesource/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def isGeospatial(path):
# TODO: log a warning
return False
try:
ds = gdal.Open(path, gdalconst.GA_ReadOnly)
ds = gdal.Open(str(path), gdalconst.GA_ReadOnly)
except Exception:
return False
if ds:
Expand Down Expand Up @@ -74,8 +74,8 @@ def getSourceNameFromDict(availableSources, pathOrUri, *args, **kwargs):
:returns: the name of a tile source that can read the input, or None if
there is no such source.
"""
uriWithoutProtocol = pathOrUri.split('://', 1)[-1]
isLargeImageUri = pathOrUri.startswith('large_image://')
uriWithoutProtocol = str(pathOrUri).split('://', 1)[-1]
isLargeImageUri = str(pathOrUri).startswith('large_image://')
extensions = [ext.lower() for ext in os.path.basename(uriWithoutProtocol).split('.')[1:]]
properties = {
'geospatial': isGeospatial(pathOrUri),
Expand Down
7 changes: 7 additions & 0 deletions large_image/tilesource/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -2332,6 +2332,13 @@ def __init__(self, path, *args, **kwargs):
:param path: a filesystem path for the tile source.
"""
super().__init__(*args, **kwargs)
# Expand the user without converting datatype of path.
try:
path = (path.expanduser() if callable(getattr(path, 'expanduser', None)) else
os.path.expanduser(path))
except TypeError:
# Don't fail if the path is unusual -- maybe a source can handle it
pass
self.largeImagePath = path

@staticmethod
Expand Down
4 changes: 2 additions & 2 deletions sources/bioformats/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,11 @@ def prerelease_local_scheme(version):
'Programming Language :: Python :: 3.10',
],
install_requires=[
'large-image>=1.0.0',
'large-image',
'python-bioformats>=1.5.2',
],
extras_require={
'girder': 'girder-large-image>=1.0.0',
'girder': 'girder-large-image',
},
keywords='large_image, tile source',
packages=find_packages(exclude=['test', 'test.*']),
Expand Down
4 changes: 2 additions & 2 deletions sources/deepzoom/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ def prerelease_local_scheme(version):
'Programming Language :: Python :: 3.10',
],
install_requires=[
'large-image>=1.0.0',
'large-image',
],
extras_require={
'girder': 'girder-large-image>=1.0.0',
'girder': 'girder-large-image',
},
keywords='large_image, tile source',
packages=find_packages(exclude=['test', 'test.*']),
Expand Down
2 changes: 1 addition & 1 deletion sources/dummy/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def prerelease_local_scheme(version):
'Programming Language :: Python :: 3.10',
],
install_requires=[
'large-image>=1.0.0',
'large-image',
],
keywords='large_image, tile source',
packages=find_packages(exclude=['test', 'test.*']),
Expand Down
4 changes: 2 additions & 2 deletions sources/gdal/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@ def prerelease_local_scheme(version):
'Programming Language :: Python :: 3.10',
],
install_requires=[
'large-image>=1.0.0',
'large-image',
'gdal',
'pyproj>=2.2.0',
],
extras_require={
'girder': 'girder-large-image>=1.0.0',
'girder': 'girder-large-image',
},
keywords='large_image, tile source',
packages=find_packages(exclude=['test', 'test.*']),
Expand Down
4 changes: 2 additions & 2 deletions sources/mapnik/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@ def prerelease_local_scheme(version):
'Programming Language :: Python :: 3.10',
],
install_requires=[
'large-image>=1.0.0',
'large-image',
'large-image-source-gdal',
'mapnik',
],
extras_require={
'girder': 'girder-large-image>=1.0.0',
'girder': 'girder-large-image',
},
keywords='large_image, tile source',
packages=find_packages(exclude=['test', 'test.*']),
Expand Down
4 changes: 2 additions & 2 deletions sources/nd2/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@ def prerelease_local_scheme(version):
'Programming Language :: Python :: 3.10',
],
install_requires=[
'large-image>=1.0.0',
'large-image',
'nd2reader>=3.3',
'importlib-metadata ; python_version < "3.8"',
],
extras_require={
'girder': 'girder-large-image>=1.0.0',
'girder': 'girder-large-image',
},
keywords='large_image, tile source',
packages=find_packages(exclude=['test', 'test.*']),
Expand Down
4 changes: 2 additions & 2 deletions sources/ometiff/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,11 @@ def prerelease_local_scheme(version):
'Programming Language :: Python :: 3.10',
],
install_requires=[
'large-image>=1.0.0',
'large-image',
'large-image-source-tiff>=1.0.0',
],
extras_require={
'girder': 'girder-large-image>=1.0.0',
'girder': 'girder-large-image',
},
keywords='large_image, tile source',
packages=find_packages(exclude=['test', 'test.*']),
Expand Down
4 changes: 2 additions & 2 deletions sources/openjpeg/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@ def prerelease_local_scheme(version):
'Programming Language :: Python :: 3.10',
],
install_requires=[
'large-image>=1.0.0',
'large-image',
'glymur>=0.8.18 ; python_version >= "3.7"',
'glymur>=0.8.18,<0.9.4 ; python_version < "3.7"',
],
extras_require={
'girder': 'girder-large-image>=1.0.0',
'girder': 'girder-large-image',
},
keywords='large_image, tile source',
packages=find_packages(exclude=['test', 'test.*']),
Expand Down
4 changes: 2 additions & 2 deletions sources/openslide/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@ def prerelease_local_scheme(version):
'Programming Language :: Python :: 3.10',
],
install_requires=[
'large-image>=1.0.0',
'large-image',
'openslide-python>=1.1.0',
'tifftools>=1.2.0',
],
extras_require={
'girder': 'girder-large-image>=1.0.0',
'girder': 'girder-large-image',
},
keywords='large_image, tile source',
packages=find_packages(exclude=['test', 'test.*']),
Expand Down
4 changes: 2 additions & 2 deletions sources/pil/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ def prerelease_local_scheme(version):
'Programming Language :: Python :: 3.10',
],
install_requires=[
'large-image>=1.0.0',
'large-image',
],
extras_require={
'girder': 'girder-large-image>=1.0.0',
'girder': 'girder-large-image',
},
keywords='large_image, tile source',
packages=find_packages(exclude=['test', 'test.*']),
Expand Down
2 changes: 1 addition & 1 deletion sources/test/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def prerelease_local_scheme(version):
'Programming Language :: Python :: 3.10',
],
install_requires=[
'large-image>=1.0.0',
'large-image',
],
keywords='large_image, tile source',
packages=find_packages(exclude=['test', 'test.*']),
Expand Down
4 changes: 2 additions & 2 deletions sources/tiff/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@ def prerelease_local_scheme(version):
'Programming Language :: Python :: 3.10',
],
install_requires=[
'large-image>=1.0.0',
'large-image',
'libtiff>=0.4.1',
'tifftools>=1.2.0',
],
extras_require={
'girder': 'girder-large-image>=1.0.0',
'girder': 'girder-large-image',
},
keywords='large_image, tile source',
packages=find_packages(exclude=['test', 'test.*']),
Expand Down
11 changes: 11 additions & 0 deletions test/test_source_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,3 +190,14 @@ def testGetAvailableNamedPalettes():

assert len(large_image.tilesource.utilities.getAvailableNamedPalettes(False)) > \
len(large_image.tilesource.utilities.getAvailableNamedPalettes(False, True))


def testExpanduserPath():
imagePath = datastore.fetch('sample_image.ptif')
assert large_image.canRead(imagePath)
absPath = os.path.abspath(imagePath)
userDir = os.path.expanduser('~') + os.sep
if absPath.startswith(userDir):
userPath = '~' + os.sep + absPath[len(userDir):]
assert large_image.canRead(userPath)
assert large_image.canRead(Path(userPath))