Memoize annotation style color. #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A significant fraction of the time preparing annotation with many elements is spent calling tinycolor. Since most elements will share colors, memoizing this speeds it up substantially.
|
When displaying a large number of rectangular annotations, this change plus OpenGeoscience/geojs#979 and OpenGeoscience/geojs#980 substantially speed up the initial render. Specifically, when showing the maximum number of rectangles (currently 25000 / 4), after the json call for the data finished, a Chrome browser was spending around 2.4 seconds preparing to display the annotations. With these three changes, it takes only around 0.6 seconds. |
jbeezley
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A significant fraction of the time preparing annotation with many elements is spent calling tinycolor. Since most elements will share colors, memoizing this speeds it up substantially.