Merge pull request #1596 from girder/tile-frames-redirect

Don't redirect tile frame images via 303
girder · Aug 2, 2024 · c777d2b · c777d2b
2 parents 3877bee + cd468fd
commit c777d2b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,10 @@
 - Speed up checks for old annotations ([#1591](../../pull/1591))
 - Improve plottable data endpoint to better fetch folder data ([#1594](../../pull/1594))
 
+### Bug Fixes
+
+- Don't redirect tile frame images via 303; they aren't rendered correctly ([#1596](../../pull/1596))
+
 ## 1.29.4
 
 ### Improvements

diff --git a/girder/girder_large_image/models/image_item.py b/girder/girder_large_image/models/image_item.py
@@ -410,7 +410,8 @@ def _getAndCacheImageOrData(
             if pickleCache:
                 data = File().open(existing).read()
                 return pickle.loads(data), 'application/octet-stream'
-            return File().download(existing, contentDisposition=contentDisposition)
+            return File().download(existing, contentDisposition=contentDisposition,
+                                   headers=kwargs.get('headers', True))
         if checkAndCreate == 'check':
             return False
         return self.getAndCacheImageOrDataRun(
@@ -563,7 +564,7 @@ def tileFrames(self, item, checkAndCreate='nosave', **kwargs):
         imageKey = 'tileFrames'
         return self._getAndCacheImageOrData(
             item, 'tileFrames', checkAndCreate,
-            dict(kwargs, imageKey=imageKey), **kwargs)
+            dict(kwargs, imageKey=imageKey), headers=False, **kwargs)
 
     def getPixel(self, item, **kwargs):
         """