-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .NET 9 as target framework, fine-tune dependabot, update CI and clean tests removing .NET 6/7 from target frameworks #639
Conversation
@@ -33,6 +33,7 @@ jobs: | |||
6.x | |||
7.x | |||
8.x | |||
9.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It it a bit weird that you install all these framework, to not have them in a matrix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that for this specific workflow, it makes more sense to have all the used .NET versions available at the same runner process. Other than this, it would trigger too many jobs. Maybe we can test this approach in another PR, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you care to support the combination of all these dotnet versions on all these operating systems, then a matrix is the way to go.
I wouldn't worry about too many jobs as these will run in parallel anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, it may be better to get specific problems. I'll open a PR testing this setup later today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
With this PR,
master
branch;How to test
Check CI.