Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET 9 as target framework, fine-tune dependabot, update CI and clean tests removing .NET 6/7 from target frameworks #639

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

64J0
Copy link
Member

@64J0 64J0 commented Jan 16, 2025

Description

With this PR,

  • I'm adding .NET 9 as a target framework;
  • Changing fantomas CI to run using ubuntu-latest;
  • Changing build-and-test push trigger to execute only for pushes to the master branch;
  • Update dependabot configuration to scan multiple directories;
  • Clean test dependencies and remove .NET 6 and 7 from target frameworks.

How to test

Check CI.

@64J0 64J0 self-assigned this Jan 16, 2025
@64J0 64J0 marked this pull request as ready for review January 16, 2025 22:00
@64J0 64J0 requested review from nojaf, TheAngryByrd and mrtz-j January 16, 2025 22:00
.github/workflows/fantomas-check.yml Outdated Show resolved Hide resolved
@@ -33,6 +33,7 @@ jobs:
6.x
7.x
8.x
9.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It it a bit weird that you install all these framework, to not have them in a matrix.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that for this specific workflow, it makes more sense to have all the used .NET versions available at the same runner process. Other than this, it would trigger too many jobs. Maybe we can test this approach in another PR, what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you care to support the combination of all these dotnet versions on all these operating systems, then a matrix is the way to go.
I wouldn't worry about too many jobs as these will run in parallel anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it may be better to get specific problems. I'll open a PR testing this setup later today

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/Giraffe.Tests/Giraffe.Tests.fsproj Outdated Show resolved Hide resolved
@64J0 64J0 changed the title Add .NET 9 as target framework Add .NET 9 as target framework, fine-tune dependabot, update CI and clean tests removing .NET 6/7 from target frameworks Jan 17, 2025
@64J0 64J0 requested a review from nojaf January 18, 2025 00:38
@64J0 64J0 merged commit 914a5ce into master Jan 20, 2025
7 checks passed
@64J0 64J0 deleted the add-dotnet-nine branch January 20, 2025 21:29
@64J0 64J0 added github_actions Pull requests that update GitHub Actions code .NET Pull requests that update .net code labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants