JS: migration à data-emplois- pour notre "setter" #5603
+39
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavfernandez
added
the
no-changelog
xavfernandez
changed the title
data-emplois- pour notre "setter"
xavfernandez
changed the title
data-emplois- pour notre "setter"
xavfernandez
force-pushed
the
xfernandez/prefix_data_attribute
branch
2 times, most recently
from
3fb6aca to
983714b
Compare
migrations.md
Outdated
Comment on lines
41
to
45
|
|
||
| ## Préfixer les attributs utilisé par notre JS par data-emplois | ||
|
|
||
| `data-bs-` est le préfixe utilisé par bootstrap, `data-it-` celui utilisé par le thème itou. | ||
| Notre JS devrait utiliser `data-emplois-`. |
There was a problem hiding this comment.
Je pense que cette doc aurait plus sa place dans docs/javascript.md?
Quitte à garder une ligne ici pour dire de se conformer aux bonnes pratiques JS qui pointe vers docs/javascript?
There was a problem hiding this comment.
On est d'accord que le docs/javascript.md n'existe pas ? 😅
L'idée serait donc d'en démarrer un ? Avec juste cette règle ?
Also remove the button restriction: it will soon be used from a span (with role="button").
xavfernandez
force-pushed
the
xfernandez/prefix_data_attribute
branch
from
983714b to
788c2cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Pour plus facilement identifier qui fournit le mécanisme utilisé.
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran