Prescripteur: ajout de tri dans la liste des candidats [GEN-1844] #5602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavfernandez
added
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
xavfernandez
force-pushed
the
xfernandez/sort_job_seekers
branch
5 times, most recently
from
e762394 to
ce7bd08
Compare
xavfernandez
changed the title
since they will be changed in next commit
xavfernandez
force-pushed
the
xfernandez/sort_job_seekers
branch
from
ce7bd08 to
81f7c29
Compare
xavfernandez
commented
Feb 14, 2025
| @@ -0,0 +1,5 @@ | |||
| <th scope="col" aria-sort="{% if order == ascending_value %}ascending{% elif order == ascending_value.opposite %}descending{% else %}none{% endif %}"> | |||
| <button type="button" data-setter-target="#id_order" data-setter-value="{% if order == ascending_value %}{{ ascending_value.opposite }}{% else %}{{ ascending_value }}{% endif %}"> | |||
There was a problem hiding this comment.
@hellodeloo @francoisfreitag je n'ai pas mis d'aria-label="Trier par {{ name }}" sur le bouton car j'ai l'impression que cela "écraserait" le nom du <th>.
Dans l'exemple: https://www.w3.org/WAI/ARIA/apg/patterns/table/examples/sortable-table/ il n'y en a pas non plus, en se contentant du aria-sort...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran