Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPS: Ajouter une section au menu de gauche pour les pros du Gard #5567

Merged
merged 7 commits into from
Feb 13, 2025
Merged

GPS: Ajouter une section au menu de gauche pour les pros du Gard #5567

merged 7 commits into from
Feb 13, 2025

Conversation

tonial
Copy link
Contributor

@tonial tonial commented Feb 7, 2025

🤔 Pourquoi ?

https://www.notion.so/gip-inclusion/Parcours-d-acc-s-GPS-dans-le-Gard-menu-lat-ral-dashboard-bandeau-info-sur-la-liste-1915f321b60480d88b65d90d3d3ff6f9?pvs=4

🍰 Comment ?

Décrivez en quelques mots la solution retenue et mise en oeuvre, les difficultés ou problèmes rencontrés. Attirez l'attention sur les décisions d'architecture ou de conception importantes.

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?
  • Ajouter l'étiquette « Bug » ?

🏝️ Comment tester ?

Les instructions pour reproduire le problème, les profils de test, le parcours spécifique à utiliser, etc. Si vous disposez d'une recette jetable, mettre l'URL pour tester dans cette partie.

💻 Captures d'écran

@tonial tonial added the modifié label Feb 7, 2025
@tonial tonial self-assigned this Feb 7, 2025
@tonial tonial force-pushed the alaurent/gps_left_menu branch from e91f563 to 9269b0a Compare February 7, 2025 18:53
@tonial tonial mentioned this pull request Feb 10, 2025
Merged
2 tasks
@tonial tonial force-pushed the alaurent/gps_left_menu branch from 9269b0a to aadf505 Compare February 10, 2025 10:12
francoisfreitag
francoisfreitag reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@francoisfreitag francoisfreitag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le reste de la carte (les badges et le bandeau) sera pour plus tard ?

itou/utils/templatetags/nav.py Outdated Show resolved Hide resolved
itou/templates/utils/templatetags/nav.html Outdated Show resolved Hide resolved
itou/www/dashboard/views.py Outdated Show resolved Hide resolved
@tonial tonial force-pushed the alaurent/gps_left_menu branch from aadf505 to 8129acd Compare February 10, 2025 12:23
@tonial
Copy link
Contributor Author

tonial commented Feb 10, 2025

Merci pour tes retours.
En effet, j'ai loupé le bandeau.

Pour le badge, j'attends une confirmation qu'on peut, mais je vais aller demander directement, ce sera plus rapide :)

@tonial tonial force-pushed the alaurent/gps_left_menu branch from 8129acd to c9e518e Compare February 10, 2025 13:51
hellodeloo
hellodeloo reviewed Feb 10, 2025
View reviewed changes
itou/templates/gps/my_groups.html Outdated
@@ -37,6 +37,21 @@ <h1 class="m-0">Mes bénéficiaires</h1>
{% block content %}
<section class="s-section" id="gps-my-groups">
<div class="s-section__container container">
<div class="alert alert-info" role="status">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'après la maquette, j'ai l'impression que cette alerte devrait plutôt se trouver dans la section {% block title_content %}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alors j'ai un doute parce que le diviseur horizontal a disparu :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mais de toute façon, on va faire différemment avec un sous-titre (vf https://gip-inclusion.slack.com/archives/CQ6C3LSAH/p1739197144671019?thread_ts=1739194984.438729&cid=CQ6C3LSAH) donc c'est bon pour ce point

@tonial tonial force-pushed the alaurent/gps_left_menu branch 5 times, most recently from 1465066 to 44da52a Compare February 11, 2025 14:05
leo-naeka
leo-naeka approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@leo-naeka leo-naeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pour moi.

Plus clair avec le helper, mais on en a de plus en plus du genre (30, 69, 22), donc je me demande si ça vaudrait pas le coup un in_department([x, y, z] et un filter request|in_department:x,y,z car pas forcément souhaitable de modifier le contexte des vues à chaque bandeau…

tests/www/dashboard/test_dashboard.py Outdated Show resolved Hide resolved
@tonial tonial force-pushed the alaurent/gps_left_menu branch from 44da52a to b12cc0b Compare February 13, 2025 05:52
@tonial
Copy link
Contributor Author

tonial commented Feb 13, 2025

C'est une chouette idée, mais pour cette PR ça ne changerai pas grand chose : dans les deux cas je fait l'appel depuis le code python car

  • soit c'est déjà dans un templatetag (nav menu)
  • soit c'est combiné à un autre helper (is_allowed_to_use_gps) que je n'ai pas très envie d'ajouter en templatetag

@tonial tonial force-pushed the alaurent/gps_left_menu branch from b12cc0b to 9204c6e Compare February 13, 2025 06:07
@tonial
gps: Clean unused helper calls
efd6121 
The helper will soon be used again, so we keep it
@tonial
gps: Improve gps card test
d11c21f 
We don't have a partial card anymore
@tonial
templatetags: Allow "new" badge on nav items
b5f5892
@tonial
www: Add new GPS item to nav bar
7124a9d 
When the employer/prescriber's organization department is 30
@tonial
gps: Add info componant on main page
175c284
@tonial tonial force-pushed the alaurent/gps_left_menu branch from 9204c6e to 3f9ad83 Compare February 13, 2025 10:14
@tonial tonial enabled auto-merge February 13, 2025 10:16
@tonial tonial force-pushed the alaurent/gps_left_menu branch from 3f9ad83 to 0681f8a Compare February 13, 2025 10:22
@tonial tonial added this pull request to the merge queue Feb 13, 2025
Merged via the queue into master with commit 3b8bdec Feb 13, 2025
11 checks passed
@tonial tonial deleted the alaurent/gps_left_menu branch February 13, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoisfreitag francoisfreitag francoisfreitag left review comments

@hellodeloo hellodeloo hellodeloo left review comments

@leo-naeka leo-naeka leo-naeka approved these changes

Assignees

@tonial tonial

Labels
modifié
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tonial @leo-naeka @francoisfreitag @hellodeloo