Performance: suppression de la vérification systématique de la disponibilité des images dans la page nouveautés #5549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is quite costly for a limited impact
calummackervoy
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
C'était ajouté pour protéger défensivement (si par example les permissions changent sur le bucket). Si c'est couteaux je ne pense pas que ça vaut le coup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
C'est finalement assez couteux sur la page contenant beaucoup de liens.
Cf https://inclusion.sentry.io/insights/backend/trace/3bbb8aac461f4289b2eaccfe0ff6a140/
Et #5453 permettra d'être alerté en cas de soucis.
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran