Candidature: réutilisation du traitement par lot pour le refus d'une seule candidature #5502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavfernandez
added
the
no-changelog
xavfernandez
added
the
1-recette-jetable
xavfernandez
commented
Jan 30, 2025
| name="refuse", | ||
| ), | ||
| # TODO(xfernandez): remove this path in a week | ||
| path( | ||
| "<uuid:job_application_id>/siae/refuse/<slug:step>", | ||
| process_views.JobApplicationRefuseView.as_view(url_name="refuse"), |
There was a problem hiding this comment.
Je garde ce chemin accessible et sans test pour ne pas casser les parcours en cours.
Ce chemin n'ayant plus de "name" plus aucun utilisateur ne devrait y être redirigé.
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
tonial
approved these changes
Jan 30, 2025
| "step_data": {}, | ||
| "step_files": {}, | ||
| "extra_data": {}, | ||
| [refuse_session_name] = [k for k in client.session.keys() if k not in KNOWN_SESSION_KEYS] |
There was a problem hiding this comment.
il nous faudrait un helper pour remplacer ce
[k for k in client.session.keys() if k not in KNOWN_SESSION_KEYS]
xavfernandez
force-pushed
the
xfernandez/reuse_batch_refuse_for_single_refuse
branch
6 times, most recently
from
0cb2a0d to
76a44c9
Compare
xavfernandez
force-pushed
the
xfernandez/reuse_batch_refuse_for_single_refuse
branch
from
76a44c9 to
4168dcf
Compare
xavfernandez
deleted the
xfernandez/reuse_batch_refuse_for_single_refuse
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Les deux parcours sont censés suivre la même logique.
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester ?
💻 Captures d'écran