Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPS: suivre automatiquement les candidats lors de certaines actions #5501

Merged
merged 10 commits into from
Jan 31, 2025
Merged

GPS: suivre automatiquement les candidats lors de certaines actions #5501

merged 10 commits into from
Jan 31, 2025

Conversation

tonial
Copy link
Contributor

@tonial tonial commented Jan 30, 2025 •
edited
Loading

🤔 Pourquoi ?

Pour maintenir les groupes à jour, on rejoint (ou crée) le groupe de suivi d'un candidat dès que l'on :

  • ajoute un bénéficiaire (parcours qui n'est plus accessible depuis qu'on a retiré l'autocomplete)
  • postule pour un candidat
  • accepte une candidature
  • établir un diagnostic (IAE ou GEIQ) pour un candidat

https://www.notion.so/gip-inclusion/B-tonner-la-synchronisation-avec-les-Emplois-17a5f321b60480279d73f2ef91f28900?pvs=4

Une autre PR suivra pour rattraper le backlog depuis la commande d'initialisation.

🍰 Comment ?

Décrivez en quelques mots la solution retenue et mise en oeuvre, les difficultés ou problèmes rencontrés. Attirez l'attention sur les décisions d'architecture ou de conception importantes.

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?
  • Ajouter l'étiquette « Bug » ?

🏝️ Comment tester ?

Les instructions pour reproduire le problème, les profils de test, le parcours spécifique à utiliser, etc. Si vous disposez d'une recette jetable, mettre l'URL pour tester dans cette partie.

💻 Captures d'écran

@tonial tonial self-assigned this Jan 30, 2025
leo-naeka
leo-naeka approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@leo-naeka leo-naeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

tests/www/apply/test_submit.py Outdated Show resolved Hide resolved
leo-naeka
leo-naeka approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@leo-naeka leo-naeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@tonial tonial force-pushed the alaurent/gps_sync_groups branch from 925b954 to d1a77ce Compare January 30, 2025 14:38
EwenKorr
EwenKorr approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@EwenKorr EwenKorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plein de petits commits ✨

@tonial tonial force-pushed the alaurent/gps_sync_groups branch from d1a77ce to 68ab077 Compare January 30, 2025 20:50
tonial added 10 commits January 30, 2025 22:04
@tonial
gps: Add new field to FollowUpGroupMembership
eb15411 
This will allow us to track the last contact the user made
with the job seeker, allowing a better display order and
a mean to archive old memberships
@tonial
tests: improve gps test using refresh_from_db()
1441f63
@tonial
gps: Stop naming the arguments when calling follow_beneficiary
2a3468e
@tonial
gps: Use update_or_create in follow_beneficiary
584a731
@tonial
gps: Make is_referent optionnal in follow_beneficiary
52ab19e
@tonial
gps: Update last_contact_at in follow_beneficiary
4a36742 
We don't use updated_at as it might change when performing another
action because of that auto_now
@tonial
gps: Follow job seeker when creating a geiq eligibility diagnosis
1ecbde2
@tonial
gps: Follow job seeker when creating a iae eligibility diagnosis
d38787d
@tonial
gps: Follow job seeker when applying for him
aebb1b3 
If he's not the sender
@tonial
gps: follow job seeker when accepting a job application
936306e
@tonial tonial force-pushed the alaurent/gps_sync_groups branch from 68ab077 to 936306e Compare January 30, 2025 21:05
@tonial tonial added this pull request to the merge queue Jan 31, 2025
Merged via the queue into master with commit 5692e6d Jan 31, 2025
9 checks passed
@tonial tonial deleted the alaurent/gps_sync_groups branch January 31, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwenKorr EwenKorr EwenKorr approved these changes

@leo-naeka leo-naeka leo-naeka approved these changes

@xavfernandez xavfernandez Awaiting requested review from xavfernandez

@francoisfreitag francoisfreitag Awaiting requested review from francoisfreitag

Assignees

@tonial tonial

Labels
modifié
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonial @leo-naeka @EwenKorr