Utiliser JobSeekerProfileFieldMixin pour JobSeekerPersonalDataForm #5449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the inheritance for JobSeekerNIRUpdateMixin, as all forms are now based on the User model, and consolidate implementation of user profile fields on JobSeekerProfileFieldMixin. Because fields are now added to JobSeekerPersonalDataForm dynamically by the JobSeekerProfileFieldMixin, `base_fields` are empty. Use the birthdate field on the form instance to perform the validation. That’s also a bit safer, as we don’t risk making changes to the reused base_fields for other requests.
francoisfreitag
added
the
no-changelog
xavfernandez
approved these changes
Jan 23, 2025
celine-m-s
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Consolider l’implémentation de la modification du profil utilisateur.
🍰 Comment ?
Voir le message de commit.