Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Candidature: Prévenir dans la candidature que la personne a quitté l’organisation #4916

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Candidature: Prévenir dans la candidature que la personne a quitté l’organisation #4916

merged 3 commits into from
Jan 7, 2025

Conversation

tonial
Copy link
Contributor

@tonial tonial commented Oct 14, 2024

🤔 Pourquoi ?

Simplifier la prise de contact avec le référent.
Il faut mettre en place l'envoi des réponses aux administrateurs avant ce ticket en revanche

🍰 Comment ?

Décrivez en quelques mots la solution retenue et mise en oeuvre, les difficultés ou problèmes rencontrés. Attirez l'attention sur les décisions d'architecture ou de conception importantes.

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?

🏝️ Comment tester

Les instructions pour reproduire le problème, les profils de test, le parcours spécifique à utiliser, etc. Si vous disposez d'une recette jetable, mettre l'URL pour tester dans cette partie.

💻 Captures d'écran

@tonial tonial self-assigned this Oct 14, 2024
@notion-workspace Notion Workspace
Copy link

🌿 [Référents & Réattribution] Prévenir dans la candidature que la personne a quitté l’organisation

@tonial tonial force-pushed the alaurent/point_of_contact_left branch from 4f2fab8 to 575e568 Compare October 14, 2024 04:58
@tonial tonial changed the title Candidature: Prévenir dans la candidature que la personne a quitté l’organisation [GEN-1824] Candidature: Prévenir dans la candidature que la personne a quitté l’organisation Oct 14, 2024
leo-naeka
leo-naeka reviewed Oct 14, 2024
View reviewed changes
tests/job_applications/test_models.py Outdated Show resolved Hide resolved
tests/www/apply/test_process.py Outdated Show resolved Hide resolved
tests/www/apply/test_process.py Outdated Show resolved Hide resolved
@tonial tonial force-pushed the alaurent/point_of_contact_left branch 3 times, most recently from 6046f3c to 4ccf5ab Compare October 14, 2024 10:03
francoisfreitag
francoisfreitag reviewed Oct 15, 2024
View reviewed changes
itou/job_applications/models.py Outdated Show resolved Hide resolved
itou/job_applications/models.py Outdated Show resolved Hide resolved
itou/templates/apply/includes/job_application_sender_info.html Show resolved Hide resolved
tests/www/apply/test_process.py Outdated Show resolved Hide resolved
@tonial tonial force-pushed the alaurent/point_of_contact_left branch 4 times, most recently from 1cf921a to c6be5a8 Compare October 17, 2024 11:52
@notion-workspace Notion Workspace
Copy link

🌿 [Référents & Réattribution] Prévenir dans la candidature que la personne a quitté l’organisation

1 similar comment
@notion-workspace Notion Workspace
Copy link

🌿 [Référents & Réattribution] Prévenir dans la candidature que la personne a quitté l’organisation

@tonial tonial force-pushed the alaurent/point_of_contact_left branch from c6be5a8 to 2271124 Compare October 23, 2024 03:49
@tonial tonial force-pushed the alaurent/point_of_contact_left branch from 2271124 to 2c32d03 Compare November 16, 2024 04:52
@tonial tonial force-pushed the alaurent/point_of_contact_left branch 4 times, most recently from 24fad62 to 2a11929 Compare December 4, 2024 05:42
@tonial
Copy link
Contributor Author

tonial commented Dec 4, 2024

@leo-naeka j'ai enfin pu reprendre cette PR et gérer l'envoi aux admins.
Je ne suis pas super convaincu de la manière dont je gère cette copie envoyée au admins car j'ai l'impression de détourner un peu le fonctionnement des notifications, mais en même temps si on veut que ce soit systématiquement utilisé et qu'on n'oublie pas de le faire sur les prochaine notifications je ne vois pas comment faire autrement.
Est-ce que cette approche te semble aller dans la bonne direction ?

@tonial tonial force-pushed the alaurent/point_of_contact_left branch from 2a11929 to 7354e39 Compare December 4, 2024 05:54
@tonial tonial force-pushed the alaurent/point_of_contact_left branch 3 times, most recently from 85307d0 to 390f205 Compare December 17, 2024 21:56
@tonial tonial force-pushed the alaurent/point_of_contact_left branch from 390f205 to 6e6a648 Compare December 17, 2024 22:09
@tonial tonial requested a review from leo-naeka December 17, 2024 22:10
@tonial
Copy link
Contributor Author

tonial commented Dec 17, 2024

@leo-naeka c'est bon, j'ai un truc plus ou moins satisfaisant transférer les notifs aux admins

@tonial
Copy link
Contributor Author

tonial commented Dec 17, 2024

@leo-naeka c'est bon, j'ai un truc plutôt satisfaisant pour transférer les notifications aux administrateurs. Tu en penses quoi ?

leo-naeka
leo-naeka reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@leo-naeka leo-naeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good !

Juste quelques remarques liées aux notifs, mais pas grand chose :)

itou/communications/dispatch/email.py Outdated Show resolved Hide resolved
itou/communications/dispatch/email.py Outdated Show resolved Hide resolved
itou/communications/dispatch/email.py Show resolved Hide resolved
itou/communications/dispatch/email.py Outdated Show resolved Hide resolved
itou/communications/dispatch/email.py Outdated Show resolved Hide resolved
xavfernandez
xavfernandez reviewed Dec 20, 2024
View reviewed changes
itou/communications/dispatch/email.py Outdated Show resolved Hide resolved
itou/communications/dispatch/email.py Outdated Show resolved Hide resolved
@tonial tonial force-pushed the alaurent/point_of_contact_left branch 2 times, most recently from 26dedf4 to 7b36131 Compare December 31, 2024 06:29
xavfernandez
xavfernandez reviewed Jan 6, 2025
View reviewed changes
itou/communications/dispatch/base.py Show resolved Hide resolved
itou/communications/dispatch/email.py Outdated Show resolved Hide resolved
itou/templates/layout/base_email_text_body.txt Outdated Show resolved Hide resolved
@tonial tonial force-pushed the alaurent/point_of_contact_left branch from 7b36131 to b1db4ea Compare January 6, 2025 15:43
@tonial tonial requested a review from xavfernandez January 6, 2025 15:44
xavfernandez
xavfernandez reviewed Jan 6, 2025
View reviewed changes
itou/templates/layout/base_email_text_body.txt Outdated Show resolved Hide resolved
itou/www/apply/views/submit_views.py Outdated
@@ -700,6 +700,7 @@ def form_valid(self):
company_recipients = User.objects.filter(
companymembership__company=job_application.to_company,
companymembership__is_active=True,
is_active=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bien vu mais ça mériterait bien un petit test 👀 , peut-être même dans une autre PR 👼 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il y a 2 commits qui mériteraient des tests, Je vais en effet les sortir dans une autre PR pour ajouter les tests qui vont bien. J'ai pas eu le temps aujourd'hui

@tonial tonial force-pushed the alaurent/point_of_contact_left branch from b1db4ea to 9cfe60c Compare January 6, 2025 20:51
@tonial tonial requested a review from xavfernandez January 6, 2025 20:55
@tonial tonial force-pushed the alaurent/point_of_contact_left branch from 9cfe60c to 37c46c3 Compare January 6, 2025 20:55
@tonial tonial force-pushed the alaurent/point_of_contact_left branch from 37c46c3 to c19fdbb Compare January 6, 2025 21:45
@tonial tonial added this pull request to the merge queue Jan 7, 2025
Merged via the queue into master with commit 4f542a0 Jan 7, 2025
11 checks passed
@tonial tonial deleted the alaurent/point_of_contact_left branch January 7, 2025 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavfernandez xavfernandez xavfernandez approved these changes

@leo-naeka leo-naeka Awaiting requested review from leo-naeka

@francoisfreitag francoisfreitag Awaiting requested review from francoisfreitag

Assignees

@tonial tonial

Labels
modifié
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tonial @leo-naeka @xavfernandez @francoisfreitag