Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: add http.status_code key to request logs #3971

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

xavfernandez
Copy link
Contributor

@xavfernandez xavfernandez commented Apr 24, 2024

🤔 Pourquoi ?

Pour avoir le code HTTP dans les logs.

🍰 Comment ?

Le setting DJANGO_DATADOG_LOGGER_EXTRA_INCLUDE permet d'inclure les extra fourni au logger dans le log JSON.
Dans notre cas, la clef http.status_code.

🚨 À vérifier

  • Ajouter l'étiquette « no-changelog » ?
  • Mettre à jour le CHANGELOG_breaking_changes.md ?

🏝️ Comment tester

Lancer en dev, enlever le code supprimant le formatter JSON dans config/settings/dev.py et tester une requête.

@xavfernandez xavfernandez added the no-changelog Ne doit pas figurer dans le journal des changements. label Apr 24, 2024
@xavfernandez xavfernandez self-assigned this Apr 24, 2024
@xavfernandez xavfernandez enabled auto-merge April 24, 2024 13:11
@xavfernandez xavfernandez added this pull request to the merge queue Apr 24, 2024
@xavfernandez xavfernandez removed this pull request from the merge queue due to a manual request Apr 24, 2024
@xavfernandez xavfernandez added this pull request to the merge queue Apr 25, 2024
@xavfernandez xavfernandez removed this pull request from the merge queue due to a manual request Apr 25, 2024
@xavfernandez xavfernandez force-pushed the xfernandez/datadog_status_code branch from a96f4a7 to 7e69310 Compare April 25, 2024 13:46
@xavfernandez xavfernandez enabled auto-merge April 25, 2024 13:46
@xavfernandez xavfernandez added this pull request to the merge queue Apr 25, 2024
Merged via the queue into master with commit 4dabc06 Apr 25, 2024
11 checks passed
@xavfernandez xavfernandez deleted the xfernandez/datadog_status_code branch April 25, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Ne doit pas figurer dans le journal des changements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants