Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPS : ajout d'un feature flag #3930

Merged
merged 1 commit into from
Apr 22, 2024
Merged

GPS : ajout d'un feature flag #3930

merged 1 commit into from
Apr 22, 2024

Conversation

celine-m-s
Copy link
Collaborator

🤔 Pourquoi ?

Activation de la fonctionnalité GPS dans tous les environnements sauf en prod.

🚨 À vérifier

  • Ajouter l'étiquette « no-changelog » ?
  • Mettre à jour le CHANGELOG_breaking_changes.md ?

@celine-m-s celine-m-s self-assigned this Apr 15, 2024
@celine-m-s celine-m-s added the no-changelog Ne doit pas figurer dans le journal des changements. label Apr 15, 2024
@celine-m-s celine-m-s requested a review from vjousse April 15, 2024 15:53
@celine-m-s celine-m-s marked this pull request as ready for review April 15, 2024 15:58
vjousse
vjousse approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@vjousse vjousse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'avoue que je me serais attendu à un enum pour la valeur de ITOU_ENVIRONMENT mais ça semble être une string partout autre part dans le code, donc c'est ok pour moi 👍

@celine-m-s celine-m-s added this pull request to the merge queue Apr 22, 2024
@celine-m-s
Copy link
Collaborator Author

J'avoue que je me serais attendu à un enum pour la valeur de ITOU_ENVIRONMENT mais ça semble être une string partout autre part dans le code, donc c'est ok pour moi

Moi aussi mais bon, code legacy.

Merged via the queue into master with commit b001861 Apr 22, 2024
10 checks passed
@celine-m-s celine-m-s deleted the celinems/gps-feat-flag branch April 22, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjousse vjousse vjousse approved these changes

Assignees

@celine-m-s celine-m-s

Labels
no-changelog Ne doit pas figurer dans le journal des changements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@celine-m-s @vjousse