refactor: suppression du signal post_create au profit d'un appel direct à la méthode create_post_notifications
#910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calummackervoy
previously approved these changes
Feb 13, 2025
vincentporte
dismissed stale reviews from calummackervoy and francoisfreitag
via
c146f20
vincentporte
force-pushed
the
909-supprimer-le-signal-post_create
branch
from
fd0f0c1 to
c146f20
Compare
vincentporte
added a commit
that referenced
this pull request
Feb 13, 2025
…rect à la méthode `create_post_notifications` (#910) ## Description 🎸 cf titre ## Type de changement 🚧 technique ### Points d'attention 🦺 Bien que déclenché dans la méthode `save` du modèle `Post`, la méthode n'est appelée que lors de la création d'une nouvelle instance de `Post`. Pas de risque d'envoi massif de notifications en cas de `save` en masse sur des instances existantes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🎸 cf titre
Type de changement
🚧 technique
Points d'attention
🦺 Bien que déclenché dans la méthode
savedu modèlePost, la méthode n'est appelée que lors de la création d'une nouvelle instance dePost. Pas de risque d'envoi massif de notifications en cas desaveen masse sur des instances existantes.