#2269 - La liste des utilisateurs des agences accompagnantes est mise à jour en fonction de l'agence prescriptrice #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clement-duport
temporarily deployed
to
review-app
GitHub Actions
Inactive
clement-duport
changed the title
clement-duport
temporarily deployed
to
review-app
GitHub Actions
Inactive
|
Review app: |
enguerranws
changed the title
enguerranws
reviewed
Oct 4, 2024
back/src/domains/inclusion-connected-users/use-cases/CreateUserForAgency.unit.test.ts
Outdated
Show resolved
Hide resolved
back/src/domains/inclusion-connected-users/use-cases/CreateUserForAgency.unit.test.ts
Outdated
Show resolved
Hide resolved
| @@ -99,7 +99,7 @@ describe("SendEmailWhenAgencyIsActivated", () => { | |||
| }, | |||
| agencyRights: [ | |||
| { | |||
| roles: ["to-review"], | |||
| roles: ["counsellor"], | |||
There was a problem hiding this comment.
Je comprends pas trop pourquoi les valeurs ont changés ici, je m'attendais à ce que le test de ce usecase ne change pas
There was a problem hiding this comment.
Le test a changé car avant on passait directement les roles dans le .execute() du usecase, alors que maintenant on va les chercher en DB. Donc il faut que les rôles en DB ne soit pas "in-review": on ne copie les valideurs de la structure prescriptrice parents que si l'utilisateur n'est pas "in-review".
Avant, ce test n'était pas cohérent.
| @@ -151,11 +151,8 @@ describe("SendEmailWhenAgencyIsActivated", () => { | |||
| uow.userRepository.setInclusionConnectedUsers([icUser]); | |||
|
|
|||
| await notifyIcUserAgencyRightChanged.execute({ | |||
| roles: ["to-review"], | |||
There was a problem hiding this comment.
J'imagine que pour ce usecase de notif, les roles / isNotifiedByEmail / email ne sont pas nécessaires en fait ? (on en fait plus rien dans le usecase ni dans le mail)
back/src/domains/convention/use-cases/notifications/NotifyIcUserAgencyRightChanged.ts
Show resolved
Hide resolved
back/src/domains/agency/use-cases/UpdateAgencyReferingToUpdatedAgency.unit.test.ts
Outdated
Show resolved
Hide resolved
celineung
force-pushed
the
2269-vrifier-qu-chaque-modification-de-valideur-dune-structure-prescriptrice-les-valideurs-de-la-structure-daccompagnement-sont-aussi-crs
branch
from
778a0e2
to
00e1fb1
Compare
celineung
force-pushed
the
2269-vrifier-qu-chaque-modification-de-valideur-dune-structure-prescriptrice-les-valideurs-de-la-structure-daccompagnement-sont-aussi-crs
branch
from
00e1fb1
to
1d8a20d
Compare
celineung
force-pushed
the
2269-vrifier-qu-chaque-modification-de-valideur-dune-structure-prescriptrice-les-valideurs-de-la-structure-daccompagnement-sont-aussi-crs
branch
from
1d8a20d
to
89be2c4
Compare
enguerranws
approved these changes
Oct 4, 2024
|
|
celineung
force-pushed
the
2269-vrifier-qu-chaque-modification-de-valideur-dune-structure-prescriptrice-les-valideurs-de-la-structure-daccompagnement-sont-aussi-crs
branch
from
09aaa8a
to
0d8bb5b
Compare
celineung
force-pushed
the
2269-vrifier-qu-chaque-modification-de-valideur-dune-structure-prescriptrice-les-valideurs-de-la-structure-daccompagnement-sont-aussi-crs
branch
from
0d8bb5b
to
ec0fd97
Compare
enguerranws
approved these changes
Oct 10, 2024
copy agency validator emails that do not receive notification to agencies with refersTo
celineung
force-pushed
the
2269-vrifier-qu-chaque-modification-de-valideur-dune-structure-prescriptrice-les-valideurs-de-la-structure-daccompagnement-sont-aussi-crs
branch
from
ec0fd97
to
71e73dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mettre à jour les mails des valideurs de la structure d'accompagnement lorsque ceux de la structure prescriptrice parente ont changé.
Pour la mise à jour des infos déjà présentes en DB, les requêtes SQL à jouer sur la prod après mep de cette PR sont dans le ticket: #2269