refactor createUserOnAgencyEpic after review

gip-inclusion · Sep 9, 2024 · 6aa6c32 · 6aa6c32
1 parent 66d7599
commit 6aa6c32
Showing 1 changed file with 14 additions and 30 deletions.
diff --git a/front/src/core-logic/domain/admin/icUsersAdmin/icUsersAdmin.epics.ts b/front/src/core-logic/domain/admin/icUsersAdmin/icUsersAdmin.epics.ts
@@ -132,36 +132,20 @@ const createUserOnAgencyEpic: IcUsersAdminActionEpic = (
       adminGateway
         .createUserForAgency$(action.payload, getAdminToken(state$.value))
         .pipe(
-          map(
-            ({
-              id,
-              email,
-              firstName,
-              lastName,
-              createdAt,
-              dashboards,
-              externalId,
-              agencyRights,
-            }) =>
-              icUsersAdminSlice.actions.createUserOnAgencySucceeded({
-                icUser: {
-                  id,
-                  email,
-                  firstName,
-                  lastName,
-                  externalId,
-                  createdAt,
-                  dashboards,
-                  agencyRights: agencyRights.reduce(
-                    (agenciesAcc, agencyRight) => ({
-                      ...agenciesAcc,
-                      [agencyRight.agency.id]: agencyRight,
-                    }),
-                    {} as Record<AgencyId, AgencyRight>,
-                  ),
-                },
-                feedbackTopic: action.payload.feedbackTopic,
-              }),
+          map((user) =>
+            icUsersAdminSlice.actions.createUserOnAgencySucceeded({
+              icUser: {
+                ...user,
+                agencyRights: user.agencyRights.reduce(
+                  (agenciesAcc, agencyRight) => ({
+                    ...agenciesAcc,
+                    [agencyRight.agency.id]: agencyRight,
+                  }),
+                  {} as Record<AgencyId, AgencyRight>,
+                ),
+              },
+              feedbackTopic: action.payload.feedbackTopic,
+            }),
           ),
           catchEpicError((error) =>
             icUsersAdminSlice.actions.createUserOnAgencyFailed({