chore(dev) : Do not restart docker images in dev #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlecuyer
approved these changes
Oct 8, 2024
vperron
force-pushed
the
vperron/no-restart
branch
from
9305506
to
b8e7865
Compare
The 'on-failure' setting makes the images restart almost all the time, especially upon reboot, if I work on this project or not. This is good in a production setting, but in development, restarting after a reboot on my personal computer drains my battery for no good reason. Furthermore, if there was an actual issue with the containers in development, they should just stop and the developer should fix the issue, not run into a mindless loop till oblivion.
vperron
force-pushed
the
vperron/no-restart
branch
from
b8e7865
to
8ead62f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'on-failure' setting makes the images restart almost all the time, especially upon reboot, if I work on this project or not.
This is good in a production setting, but in development, restarting after a reboot on my personal computer drains my battery for no good reason.
Furthermore, if there was an actual issue with the containers in development, they should just stop and the developer should fix the issue, not run into a mindless loop till oblivion.