feat(brevo) : Hide contacts properly for all sources #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmttn
reviewed
Sep 27, 2024
vmttn
reviewed
Sep 27, 2024
Comment on lines
+40
to
+41
| SELECT DISTINCT | ||
| UNNEST(contact_uids) AS id, |
There was a problem hiding this comment.
Suggested change
| SELECT DISTINCT | |
| UNNEST(contact_uids) AS id, | |
| SELECT | |
| DISTINCT UNNEST(contact_uids) AS id, |
There was a problem hiding this comment.
c'est pas moi c'est sqlfluff.
When a contact has stated an opposition and/or has been blacklisted, handle it correctly, whatever the source. This time, it is also properly tested.
vperron
force-pushed
the
vperron/brevo-2
branch
from
cc040bf
to
2b66370
Compare
|
Je m'attends à une relecture plus musclée :) |
|
@vmttn cette PR est un peu tricky je serais content d'avoir ton avis à ce sujet. @Caldagues je vais ajouter à cette PR l'implémentation pour cacher les contacts d'une structure également si on a eu opposition sur un email venant d'un service. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets traités:
Bloquer les contacts venant de mes-aides & mediation-numerique apres une opposition Brevo
==> celui-ci est généralisé à toute source
Ne pas supprimer certaines coordonnées lors d'un hardbounce Brevo