Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore : Mise à jour des dépendances #291

Merged
merged 3 commits into from
Sep 12, 2024
Merged

chore : Mise à jour des dépendances #291

merged 3 commits into from
Sep 12, 2024

Conversation

vperron
Copy link
Contributor

@vperron vperron commented Sep 11, 2024

Most rules can be shared among those two folders.

The pipeline Makefile is still too specific for it to become really
interesting to share.
@vperron vperron self-assigned this Sep 11, 2024
@vperron vperron requested a review from vmttn as a code owner September 11, 2024 16:01
Copy link
Contributor

@vmttn vmttn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MERCI, j'ai regardé rapidement les changelogs ras

@@ -0,0 +1,20 @@
PIP_TARGET ?= pyproject.toml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qu'est-ce que tu penses d'un unique makefile à la racine ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je peux en ajouter un sans probleme, qui ferait les MAJ des 3 systèmes à la suite.
Genre

all: analyse api pipeline

analyse:
    $(MAKE) -c $@

[...]

Je me demande si on peut faire quelque chose de similaire pour MAJ les dépendances terraform, ça se regarde.

@vperron vperron merged commit 34361bb into main Sep 12, 2024
8 of 9 checks passed
@vperron vperron deleted the vperron/requirements branch September 12, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants