Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpaceM datasets #47

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Add SpaceM datasets #47

merged 3 commits into from
Aug 13, 2024

Conversation

aeisenbarth
Copy link
Contributor

@aeisenbarth aeisenbarth commented Aug 9, 2024

This PR adds two SpaceM datasets as examples for metabolomics.

SpaceM datasets natively use the SpatialData format, so actually only downloading is needed but no conversion. Still, I kept the pattern of both download.py and to_zarr.py for consistency.

Work still needed:

@LucaMarconato
Copy link
Collaborator

Thanks for the contribution. I have uploaded the data to S3, updated the scripts and tested them (I have allowed . locally to test the scripts). I have also tried running the notebook on the subset data, it works.

@LucaMarconato LucaMarconato marked this pull request as ready for review August 13, 2024 15:12
@LucaMarconato
Copy link
Collaborator

I'll merge the PR.

@LucaMarconato LucaMarconato merged commit e818c97 into giovp:main Aug 13, 2024
@LucaMarconato
Copy link
Collaborator

One comment, independent of the PR. I have noticed that the labels show some interpolation effect at the border. Using transform, using the APIs from multiscale-spatial-image or using the rasterization APIs this should not occur. In case you used them you may have discovered a bug. Or did you use external methods?

Screenshot 2024-08-13 at 17 01 54

@aeisenbarth
Copy link
Contributor Author

Oh! This is a mistake in the data that I will have to fix. It seems only the small datasets were affected. Generated them by creating a new SpatialData object with only the scale1 labels (skipping scale0), and letting SpatialData build the pyramids.

I will inspect whether there is a bug, or whether I should have taken a different approach.

@aeisenbarth
Copy link
Contributor Author

@LucaMarconato, I reuploaded the fixed datasets to scratch. When you have, can you replace them? Thanks!

@LucaMarconato
Copy link
Collaborator

Great! Done 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants