fix: rerender overlay on draggable prop change for correct drag implementation #317
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mentation Current issue: We have different modes for drawing figures on the map and placing markers, that is why draggable prop is changed dynamically depending on the mode selected. At the moment to rerender overlay we do deep comparison only on lat and lng props change, do not taking into account draggable prop which causes incorrect behaviour
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
There was a problem hiding this comment.
I need to take a look at this, because it's not just about draggable, each prop you pass to children could change. This is why only lat and lng have been considered.
Maybe there's a better way of doing this, like passing a custom function to do the comparing.
giorgiabosello
requested changes
Dec 13, 2024
There was a problem hiding this comment.
I need to take a look at this, because it's not just about draggable, each prop you pass to children could change. This is why only lat and lng have been considered.
Maybe there's a better way of doing this, like passing a custom function to do the comparing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current issue:
We have different modes for drawing figures on the map and placing markers, that is why draggable prop is changed dynamically depending on the mode selected. At the moment to rerender overlay we do deep comparison only on lat and lng props change, do not taking into account draggable prop which causes incorrect behaviour