Fix parameter ordering/naming for reference (omp) batch CG #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
mod:reference
pratikvn
requested changes
Oct 18, 2024
| @@ -96,7 +96,7 @@ inline void update_x_and_r( | |||
| batch_single_kernels::compute_conj_dot_product_kernel<ValueType>( | |||
| p_entry, Ap_entry, alpha_entry); | |||
|
|
|||
| const ValueType temp = rho_old_entry.values[0] / alpha_entry.values[0]; | |||
| const ValueType temp = rho_new_entry.values[0] / alpha_entry.values[0]; | |||
There was a problem hiding this comment.
I dont think this is accurate. In this case here, rho_old is rho_new is temp here is equivalent to develop should be correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the parameter ordering of the
initializefunction for the reference+omp implementation of the batch CG. Additionally, a parameter name inupdate_x_and_ris changed to better reflect the actually used variable.