Proof of concept: Allow recycling UnwindContext allocation #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Raising MSRV is fine. I'm all for anything that can simplify this. Reducing the amount of unsafe here would be great. |
|
Closed by #703 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to give the idea from #701 a try. This implementation works, but it uses GATs so it raises the MSRV to 1.65. It's also somewhat messy in a few places - I'm particularly unhappy with the
Option<>inArrayVecwhich I had to add because you can't destructure a type which implements Drop.If addressing #701 requires Rust 1.65 anyway, and thus should be considered a breaking change, then there might be simpler options on the table. If we can eliminate or simplify the
ArrayLiketrait, it might open up simpler options.