Skip to content

Commit

Permalink
Apply review suggestion (prefer Box over Vec)
Browse files Browse the repository at this point in the history
Co-authored-by: Philip Craig <[email protected]>
  • Loading branch information
mstange and philipc authored Mar 11, 2024
1 parent 3bfe5d3 commit 364434b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/read/cfi.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1872,7 +1872,8 @@ on the heap using [`Box`]. This is the default storage type parameter for [`Unwi
You may want to supply your own storage type for one of the following reasons:
1. In rare cases you may run into failed unwinds due to the fixed stack size
used by [`StoreOnHeap`], so you may want to try a Vec-based stack instead which
used by [`StoreOnHeap`], so you may want to try a larger `Box`. If denial
of service is not a concern, then you could also try a `Vec`-based stack which
can grow as needed.
2. You may want to avoid heap allocations entirely. You can use a fixed-size
stack with in-line arrays, which will place the entire storage in-line into
Expand Down

0 comments on commit 364434b

Please sign in to comment.