Merge pull request #119 from gimlet-io/provide-tls-secret-name

Ability to provide the TLS secret name
gimlet-io · Feb 12, 2024 · c56f637 · c56f637
2 parents 3d0cbe7 + 1497dad
commit c56f637
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/charts/onechart/templates/ingress.yaml b/charts/onechart/templates/ingress.yaml
@@ -38,7 +38,7 @@ spec:
   tls:
     - hosts:
         - {{ .ingress.host | quote }}
-      secretName: {{ printf "tls-%s" $resourceName }}
+      secretName: {{ .ingress.secretName | default (printf "tls-%s" $resourceName) }}
   {{- end }}
   rules:
     - host: {{ .ingress.host | quote }}

diff --git a/charts/onechart/tests/ingress_domain_test.yaml b/charts/onechart/tests/ingress_domain_test.yaml
@@ -119,3 +119,16 @@ tests:
             - hosts:
                 - chart-example.local
               secretName: tls-release-name-chart-example-local
+  - it: Should set Ingress secret name if provided
+    set:
+      ingress:
+        host: chart-example.local
+        tlsEnabled: true
+        secretName: tls-internal
+    asserts:
+      - equal:
+          path: spec.tls
+          value:
+            - hosts:
+                - chart-example.local
+              secretName: tls-internal