fix: oci HelmRepositories don't have status (#89)

gimlet-io · Apr 11, 2024 · b124be8 · b124be8
1 parent fc6c8ec
commit b124be8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/web/src/ReadyWidget.jsx b/web/src/ReadyWidget.jsx
@@ -5,6 +5,10 @@ import { TimeLabel } from './TimeLabel'
 export function ReadyWidget(props) {
   const { resource, displayMessage, label } = props
 
+  if (resource.kind === "HelmRepository" && resource.spec.type === 'oci') {
+    return null
+  }
+
   const readyConditions = jp.query(resource.status, '$..conditions[?(@.type=="Ready")]');
   const readyCondition = readyConditions.length === 1 ? readyConditions[0] : undefined
   const ready = readyCondition && readyConditions[0].status === "True"

diff --git a/web/src/Summary.jsx b/web/src/Summary.jsx
@@ -8,8 +8,11 @@ export function Summary(props) {
   }
 
   const totalCount = resources.length
-  const readyCount = resources.filter(resourece => {
-    const readyConditions = jp.query(resourece.status, '$..conditions[?(@.type=="Ready")]');
+  const readyCount = resources.filter(resource => {
+    if (resource.kind === "HelmRepository" && resource.spec.type === 'oci') {
+      return true
+    }
+    const readyConditions = jp.query(resource.status, '$..conditions[?(@.type=="Ready")]');
     const ready = readyConditions.length === 1 && readyConditions[0].status === "True"
     return ready
   }).length