summons

tracer for debug
fixes

src/Common/Common.csproj

@@ -72,6 +72,7 @@
     <Compile Include="IO\LogLevel.cs" />
     <Compile Include="IO\SettingReadException.cs" />
     <Compile Include="IO\Settings.cs" />
+    <Compile Include="IO\Tracer.cs" />
     <Compile Include="Network\ClientHandler.cs" />
     <Compile Include="Network\ClientOperationCode.cs" />
     <Compile Include="Network\InteroperabilityOperationCode.cs" />

src/Common/Constants.cs

@@ -22,7 +22,6 @@ public static string Explain(ServerRegsitrationResponse Packet)
             }
         }
     }
-
     public enum ServerRegsitrationResponse : byte
     {
         Valid,
@@ -31,6 +30,7 @@ public enum ServerRegsitrationResponse : byte
         Full
     }
 
+    // TODO: refactor into separate files under constants folder
     #region Interaction
     public enum InteractionCode : byte
     {

src/Common/Constants/CharacterConstants.cs

@@ -967,7 +967,7 @@ public enum ThunderBreaker : int
                 Straight = 15001001,
                 SomersaultKick = 15001002,
                 Dash = 15001003,
-                Lightning = 15001004
+                LightningSprite = 15001004
             }
 
             public enum ThunderBreaker2 : int

src/Common/IO/Tracer.cs

@@ -0,0 +1,106 @@
+using System;
+
+namespace Destiny.IO
+{
+    public class Tracer
+    {
+        #region traceError
+        public static void TraceErrorMessage(string message,
+            [System.Runtime.CompilerServices.CallerMemberName] string memberName = "",
+            [System.Runtime.CompilerServices.CallerFilePath] string sourceFilePath = "",
+            [System.Runtime.CompilerServices.CallerLineNumber] int sourceLineNumber = 0)
+        {
+            Log.Error("Error message: {0}", message);
+            Log.Error("Method/Property name: {0}", memberName);
+            Log.Error("Source file path: {0}", sourceFilePath);
+            Log.Error("Source file line number: {0}", sourceLineNumber);
+        }
+
+        public static void TraceErrorMessage(string message, 
+            [System.Runtime.CompilerServices.CallerMemberName] string memberName = "",
+            [System.Runtime.CompilerServices.CallerFilePath] string sourceFilePath = "",
+            [System.Runtime.CompilerServices.CallerLineNumber] int sourceLineNumber = 0, params object[] args)
+        {
+            Log.Error("Error message: {0}", message);
+            Log.Error("Method/Property name: {0}", memberName);
+            Log.Error("Source file path: {0}", sourceFilePath);
+            Log.Error("Source file line number: {0}", sourceLineNumber);
+            Log.Error("Additional debug info: {0}", args);
+        }
+
+        public static void TraceErrorMessage(Exception e, string message,
+            [System.Runtime.CompilerServices.CallerMemberName] string memberName = "",
+            [System.Runtime.CompilerServices.CallerFilePath] string sourceFilePath = "",
+            [System.Runtime.CompilerServices.CallerLineNumber] int sourceLineNumber = 0)
+        {
+            Log.Error("Error message: {0}", message);
+            Log.Error("Method/Property name: {0}", memberName);
+            Log.Error("Source file path: {0}", sourceFilePath);
+            Log.Error("Source file line number: {0}", sourceLineNumber);
+            Log.Error("Exception information: {0}", e);
+        }
+        #endregion
+
+        #region traceWarn
+        public static void TraceWarnMessage(string message,
+            [System.Runtime.CompilerServices.CallerMemberName] string memberName = "",
+            [System.Runtime.CompilerServices.CallerFilePath] string sourceFilePath = "",
+            [System.Runtime.CompilerServices.CallerLineNumber] int sourceLineNumber = 0)
+        {
+            Log.Warn("Error message: {0}", message);
+            Log.Warn("Method/Property name: {0}", memberName);
+            Log.Warn("Source file path: {0}", sourceFilePath);
+            Log.Warn("Source file line number: {0}", sourceLineNumber);
+        }
+
+        public static void TraceWarnMessage(string message,
+            [System.Runtime.CompilerServices.CallerMemberName] string memberName = "",
+            [System.Runtime.CompilerServices.CallerFilePath] string sourceFilePath = "",
+            [System.Runtime.CompilerServices.CallerLineNumber] int sourceLineNumber = 0, params object[] args)
+        {
+            Log.Warn("Error message: {0}", message);
+            Log.Warn("Method/Property name: {0}", memberName);
+            Log.Warn("Source file path: {0}", sourceFilePath);
+            Log.Warn("Source file line number: {0}", sourceLineNumber);
+            Log.Warn("Additional debug info: {0}", args);
+        }
+
+        public static void TraceWarnMessage(Exception e, string message,
+            [System.Runtime.CompilerServices.CallerMemberName] string memberName = "",
+            [System.Runtime.CompilerServices.CallerFilePath] string sourceFilePath = "",
+            [System.Runtime.CompilerServices.CallerLineNumber] int sourceLineNumber = 0)
+        {
+            Log.Warn("Error message: {0}", message);
+            Log.Warn("Method/Property name: {0}", memberName);
+            Log.Warn("Source file path: {0}", sourceFilePath);
+            Log.Warn("Source file line number: {0}", sourceLineNumber);
+            Log.Warn("Exception information: {0}", e);
+        }
+        #endregion
+
+        #region traceInfo
+        public static void TraceInfoMessage(string message,
+            [System.Runtime.CompilerServices.CallerMemberName] string memberName = "",
+            [System.Runtime.CompilerServices.CallerFilePath] string sourceFilePath = "",
+            [System.Runtime.CompilerServices.CallerLineNumber] int sourceLineNumber = 0)
+        {
+            Log.Inform("Error message: {0}", message);
+            Log.Inform("Method/Property name: {0}", memberName);
+            Log.Inform("Source file path: {0}", sourceFilePath);
+            Log.Inform("Source file line number: {0}", sourceLineNumber);
+        }
+
+        public static void TraceInfoMessage(string message,
+            [System.Runtime.CompilerServices.CallerMemberName] string memberName = "",
+            [System.Runtime.CompilerServices.CallerFilePath] string sourceFilePath = "",
+            [System.Runtime.CompilerServices.CallerLineNumber] int sourceLineNumber = 0, params object[] args)
+        {
+            Log.Inform("Error message: {0}", message);
+            Log.Inform("Method/Property name: {0}", memberName);
+            Log.Inform("Source file path: {0}", sourceFilePath);
+            Log.Inform("Source file line number: {0}", sourceLineNumber);
+            Log.Inform("Additional debug info: {0}", args);
+        }
+        #endregion traceInfo
+    }
+}

src/Common/Network/ServerOperationCode.cs

@@ -378,7 +378,7 @@ public enum ServerOperationCode : short
         ChangeParamResult = 323,
         QuestCashResult = 324,
         CashShopOperation = 325,
-        // 326
+        //326
         //327
         //328
         //329

src/Common/Shell/Shortcuts.cs

@@ -26,7 +26,7 @@ public static void Apply()
 
                 if (System.Windows.Application.Current == null)
                 {
-                    new System.Windows.Application();
+                    var newApplication = new System.Windows.Application();
                 }
 
                 JumpList.SetJumpList(System.Windows.Application.Current, jumpList);

src/WvsCenter/WvsCenterSetup.cs

@@ -144,7 +144,7 @@ public static void Run()
             }
 
             Log.SkipLine();
-            Log.Success("Configuration is done! Center server set up for use sucessfully.");
+            Log.Success("Configuration is done! Center server set up for use successfully.");
         }
 
         private static void PopulateCenterDatabase()

src/WvsGame/Maple/Characters/Character.cs

@@ -469,6 +469,7 @@ public int Experience
                     }
                 }
 
+                /*
                 else
                 {
                     if (experience >= CharacterConstants.ExperienceTables.CharacterLevel[this.Level])
@@ -483,6 +484,7 @@ public int Experience
                         experience = CharacterConstants.ExperienceTables.CharacterLevel[this.Level] - 1;
                     }
                 }
+                */
 
                 if (this.IsInitialized && delta != 0)
                 {
@@ -2195,7 +2197,6 @@ public void EnterPortal(Packet iPacket)
             if (false) // TODO: Check if portal is onlyOnce and player already used it.
             {
                 // TODO: Send a "closed for now" portal message.
-
                 return;
             }
 

src/WvsGame/Maple/Characters/CharacterSkills.cs

@@ -41,7 +41,12 @@ public void Delete()
             }
         }
 
-        public void Cast(Packet iPacket)
+        public static Skill GetNewSkillFromInt(int skillMapleID)
+        {
+            return new Skill(skillMapleID);
+        }
+
+    public void Cast(Packet iPacket)
         {
             iPacket.ReadInt(); // NOTE: Ticks.
             int mapleID = iPacket.ReadInt();

src/WvsGame/Maple/Characters/CharacterTrocks.cs

@@ -142,6 +142,7 @@ public void Update(Packet iPacket)
                                 this.VIP.Add(mapID);
                             }
                         }
+
                         else
                         {
                             return;

src/WvsGame/Maple/Commands/Implementation/MapCommand.cs

@@ -67,8 +67,8 @@ public override void Execute(Character caller, string[] args)
                     {
                         if (true) // TODO: Check if map exists.
                             caller.ChangeMap(mapID, portalID);
-                        else
-                            caller.Notify(string.Format("[Command] Invalid map ID {0}.", mapID));
+                        //else
+                            //caller.Notify(string.Format("[Command] Invalid map ID {0}.", mapID));
                     }
                     else
                     {

src/WvsGame/Maple/Commands/Implementation/SummonCommand.cs

@@ -0,0 +1,81 @@
+using System;
+using Destiny.Maple.Characters;
+using Destiny.Maple.Life;
+
+namespace Destiny.Maple.Commands.Implementation
+{
+    public sealed class SummonCommand : Command
+    {
+        public override string Name
+        {
+            get
+            {
+                return "summon";
+            }
+        }
+
+        public override string Parameters
+        {
+            get
+            {
+                return "{ skillID | exact name } [ amount ] ";
+            }
+        }
+
+        public override bool IsRestricted
+        {
+            get
+            {
+                return true;
+            }
+        }
+
+        public override void Execute(Character caller, string[] args)
+        {
+            if (args.Length < 1)
+            {
+                this.ShowSyntax(caller);
+            }
+            else
+            {
+                int amount = 0;
+                bool isAmountSpecified;
+
+                if (args.Length > 1)
+                {
+                    isAmountSpecified = int.TryParse(args[args.Length - 1], out amount);
+                }
+                else
+                {
+                    isAmountSpecified = false;
+                }
+
+                if (amount < 1)
+                {
+                    amount = 1;
+                }
+
+                int skillID = -1;
+
+                try
+                {
+                    skillID = int.Parse(args[0]);
+                }
+                catch (FormatException)
+                {
+                    // TODO: Fetch from strings.
+                }
+
+                Skill skillToSummonFrom = CharacterSkills.GetNewSkillFromInt(skillID);
+                Summon summon = Summon.GetNewSummonFromSkill(skillToSummonFrom);
+
+                // TODO: disperse multiple spawn, they are called with identical position thus overlap
+                for (int i = 0; i < amount; i++)
+                {
+                    caller.Map.Summons.Add(summon);
+                }
+
+            }
+        }
+    }
+}

src/WvsGame/Maple/Item.cs

@@ -10,7 +10,7 @@
 
 namespace Destiny.Maple
 {
-    public class Item : Drop
+    public class Item : Drop // TODO: too big and fugly; redo
     {
         public static ItemConstants.ItemType GetType(int mapleID)
         {
@@ -93,7 +93,6 @@ public static ItemConstants.ItemType GetType(int mapleID)
 
         public List<Tuple<int, short>> Summons { get; private set; }
 
-
         public ItemConstants.ItemType Type
         {
             get