Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero-length and effectively zero-length file-handling issues #559

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Zero-length and effectively zero-length file-handling issues #559

wants to merge 2 commits into from

Conversation

arikorn
Copy link
Contributor

@arikorn arikorn commented May 1, 2019

This PR fixes several issues related to zero-length files.

  1. Most notably fixes Issue Error: The process cannot access the file because another process has locked a portion of the file. #309 "Partially locked files" (fix is in file reader so that the "partially locked" file is treated exactly the same as "fully locked" files; the fix further assumes that the "partially locked" file returns an error upon reading the first few bytes, which has been true in all cases on my Windows 10 system.)
  2. Fixes inconsistency in how zero-length files are reported. In v2.1.2, fewer total files are reported on incrementals than on initial backups because full backups count zero-length files whereas incrementals didn't. Also solves: https://forum.duplicacy.com/t/backup-of-zero-byte-files/1376
  3. Fixes a potentially fatal bug in which zero-length chunks are created and then associated with non-zero-length files. See Bundle or chunk #456 (comment)

(Sorry, have been sitting on this branch for a month but hadn't had time to organize this description.)

@arikorn
Fix some issues in which either
43bbda9 
 - zero-length chunks are created extraneously (bloating the hash arrays), or
 - zero-length chunks are assigned incorrectly, or
 - zero-length files are not handled quite right
@arikorn
More zero-length-file fixes: report the correct number of files, incl…
5aee858 
…uding zero-length files

  (so initial and incremental backups are consistent)
Treat read errors at the start of a file (Windows "partially locked files") the same as open errors,
  rather than failing the entire backup.
@arikorn arikorn changed the title Zero-length and effectively zero-length handling issues Zero-length and effectively zero-length file-handling issues May 1, 2019
@gilbertchen
Copy link
Owner

This pull request has been mentioned on Duplicacy Forum. There might be relevant details there:

https://forum.duplicacy.com/t/backup-of-zero-byte-files/1376/4

@NiJoao NiJoao mentioned this pull request Aug 5, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arikorn @gilbertchen