Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix read the docs & improve use of enum types #515

Merged
merged 9 commits into from
Jul 4, 2024
Merged

Fix read the docs & improve use of enum types #515

merged 9 commits into from
Jul 4, 2024

Conversation

gijzelaerr
Copy link
Owner

No description provided.

nikteliy
nikteliy reviewed May 11, 2024
View reviewed changes
Copy link
Contributor

@nikteliy nikteliy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! But I'm not sure about changing Areas -> Area. This might break someone's code, but on the other hand it's easy to fix. So it's fine

snap7/types.py Outdated Show resolved Hide resolved
tests/test_client.py Show resolved Hide resolved
tests/test_client.py Outdated Show resolved Hide resolved
tests/test_client.py Outdated Show resolved Hide resolved
@gijzelaerr gijzelaerr merged commit 34cdcc3 into master Jul 4, 2024
67 checks passed
@gijzelaerr gijzelaerr deleted the fix-read-the-docs branch July 4, 2024 11:56
@gijzelaerr gijzelaerr added this to the 2.0 milestone Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikteliy nikteliy nikteliy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gijzelaerr @nikteliy