-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to latest abp2dnr #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade from @ghostery/abp2dnr to @eyeo/abp2dnr - Patched @eyeo/abp2dnr not to use Node native binding - Update test cases TrackerDB filters test failed but it's not resolvable anymore. Before `normalize` function from `test/unit/helpers.js` normalized the output rule. However, it doesn't work anymore as abp2dnr throws empty array ([]) instead of partial rule ([truthy value]).
chrmod
requested changes
Jan 3, 2024
We should ensure that all TrackerDB tests pass. The point of this project is to ensure different converters behave the same. |
chrmod
approved these changes
Jan 4, 2024
chrmod
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9
Summary
@ghostery/abp2dnr
to@eyeo/abp2dnr
@eyeo/abp2dnr
not to use Node native bindingPatched
@eyeo/abp2dnr
not to use Node native bindingsNew module uses Node native bindings that cannot be used with Bunjs. Unfortunately, the use of native module removed.
../build/Release/isRegexSupported
refers to the file../build/Release/isRegexSupported.node
.TrackerDB filters test cannot be fixed
TrackerDB filters test failed but it's not resolvable anymore. Before this changes,
normalize
function fromtest/unit/helpers.js
normalized the output rule. However, it doesn't work anymore as abp2dnr throws empty array ([]) instead of partial rule ([truthy value]).I suggest to skip testing rules leading to incomplete comparison.