Change caliban-zio-http to depend on caliban-quick
#2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyri-petrou
added
the
breaking change
ghostdogpr
approved these changes
Jun 17, 2024
paulpdaniels
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Discord with @ghostdogpr, the
caliban-zio-httpmodule has been deprecated for some time now but it's still used according to the monthly package downloads.Since we don't want to be maintaining the zio-http <-> tapir interop and having to deal with any potential version conflicts, I think for the time being we can change
caliban-zio-httpto depend oncaliban-quick(instead of tapir) and use it under the hood.For most users, this requires very few API changes to essentially pass the interpreter and config directly to the method rather than using the
HttpInterpreter/WebSocketInterpreter. The only "real" issue is with users that useRequestInterceptors. However, these interceptors are not really necessary for zio-http and can somewhat easily be re-written asMiddleware.